This repository was archived by the owner on May 31, 2025. It is now read-only.
Revert "rework Eigen functions namespace hack"#436
Merged
tfoote merged 1 commit intoJan 23, 2020
Conversation
tfoote
deleted the
revert-367-add_tf2_namespace_to_avoid_name_collision
branch
rhaschke
pushed a commit
to rhaschke/geometry2
that referenced
this pull request
Jun 30, 2020
tfoote
added a commit
that referenced
this pull request
Aug 24, 2020
* Revert "rework Eigen functions namespace hack" (#436) * Fixed warnings in message_filter.h (#434) the variables are not used in function body and caused -Wunused-parameter to trigger with -Wall * Fix ambiguous call for tf2::convert on MSVC (#444) * rework ambiguous call on MSVC. Co-authored-by: Tully Foote <tfoote@osrfoundation.org> Co-authored-by: moooeeeep <moooeeeep@users.noreply.github.com> Co-authored-by: Sean Yen <seanyen@microsoft.com>
ooeygui
pushed a commit
to ms-iot/geometry2
that referenced
this pull request
Oct 12, 2022
* Fix buffer_client.py using default timeout_padding fixes ros#436 Co-authored-by: Chris Lalancette <clalancette@openrobotics.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #367
Following up build errors in downstream packages in 0.6.6 : ros/rosdistro#23469
@kejxu FYI