Skip to content

chore: remove redundant @wagmi/core dependency and overrides - #219

Merged
rtomas merged 1 commit into
mainfrom
rtomas/sao-paulo
Jul 15, 2026
Merged

chore: remove redundant @wagmi/core dependency and overrides#219
rtomas merged 1 commit into
mainfrom
rtomas/sao-paulo

Conversation

@rtomas

@rtomas rtomas commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Removes the redundant @wagmi/core dependency from the javascript-multichain, javascript-wagmi, and react-wagmi examples, since it is already provided transitively by wagmi. Also drops the now-unnecessary overrides block from react-wagmi.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@vercel

vercel Bot commented Jul 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
appkit-web-examples-multichain-react-evm-tron Ready Ready Preview, Comment Jul 15, 2026 4:02pm
appkit-web-examples-react-multichain Ready Ready Preview, Comment Jul 15, 2026 4:02pm
react-core-universal-connector Ready Ready Preview, Comment Jul 15, 2026 4:02pm
19 Skipped Deployments
Project Deployment Actions Updated (UTC)
appkit-web-examples-javascript-bitcoin Ignored Ignored Preview Jul 15, 2026 4:02pm
appkit-web-examples-javascript-ethers Ignored Ignored Preview Jul 15, 2026 4:02pm
appkit-web-examples-javascript-solana Ignored Ignored Preview Jul 15, 2026 4:02pm
appkit-web-examples-javascript-wagmi Ignored Ignored Preview Jul 15, 2026 4:02pm
appkit-web-examples-next-bitcoin Ignored Ignored Preview Jul 15, 2026 4:02pm
appkit-web-examples-next-ethers Ignored Ignored Preview Jul 15, 2026 4:02pm
appkit-web-examples-next-multichain Ignored Ignored Preview Jul 15, 2026 4:02pm
appkit-web-examples-next-solana Ignored Ignored Preview Jul 15, 2026 4:02pm
appkit-web-examples-next-wagmi Ignored Ignored Preview Jul 15, 2026 4:02pm
appkit-web-examples-react-bitcoin Ignored Ignored Preview Jul 15, 2026 4:02pm
appkit-web-examples-react-core-up Ignored Ignored Preview Jul 15, 2026 4:02pm
appkit-web-examples-react-ethers Ignored Ignored Preview Jul 15, 2026 4:02pm
appkit-web-examples-react-ethers5 Ignored Ignored Preview Jul 15, 2026 4:02pm
appkit-web-examples-react-solana Ignored Ignored Preview Jul 15, 2026 4:02pm
appkit-web-examples-vue-bitcoin Ignored Ignored Preview Jul 15, 2026 4:02pm
appkit-web-examples-vue-ethers Ignored Ignored Preview Jul 15, 2026 4:02pm
appkit-web-examples-vue-multichain Ignored Ignored Preview Jul 15, 2026 4:02pm
appkit-web-examples-vue-solana Ignored Ignored Preview Jul 15, 2026 4:02pm
appkit-web-examples-vue-wagmi Ignored Ignored Preview Jul 15, 2026 4:02pm

Request Review

@claude

claude Bot commented Jul 15, 2026

Copy link
Copy Markdown

Claude finished @rtomas's task in 2m 32s —— View job


Review

  • Gather context
  • Read changed files
  • Run license compliance subagent
  • Run breaking changes subagent
  • Post review findings

The react/react-wagmi change is clean — no source files import @wagmi/core directly there, and dropping the overrides block is safe.

However, the two javascript examples have a critical problem: both source files still import directly from @wagmi/core after it is removed as an explicit dependency.

Found 1 issue(s)

Issue 1: Source files import @wagmi/core after it's removed as an explicit dependency

ID: javascript-wagmi-phantom-dep-a3c7
File: javascript/javascript-wagmi/src/services/wallet.js:2, javascript/javascript-multichain/src/services/walletWagmi.js:2
Severity: HIGH
Category: breaking_change

Context:

  • Pattern: Both files do import { sendTransaction, getBalance as getBalanceWagmi } from '@wagmi/core' but @wagmi/core is no longer a declared dependency in either project's package.json.
  • Risk: pnpm (required by this repo's CLAUDE.md) enforces strict node_modules isolation and does not hoist transitive packages. @wagmi/core is a transitive dep of wagmi, but pnpm will not symlink it into each project's own node_modules, so the import is unresolvable at build time.
  • Impact: pnpm install && pnpm dev (or pnpm build) will throw a module-not-found error for both javascript examples immediately after this PR merges.
  • Trigger: Any fresh install using pnpm. npm users won't notice because npm hoists all transitive packages.

Recommendation: Change the import source from @wagmi/core to wagmi (which re-exports all core actions):

// Before
import { sendTransaction, getBalance as getBalanceWagmi } from '@wagmi/core'

// After
import { sendTransaction, getBalance as getBalanceWagmi } from 'wagmi'

Also note: getBalanceWagmi is imported but never called in either file (the getBalance export uses a raw provider.request call instead). That dead import can be removed.

Fix this →

License compliance: No issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant