Skip to content

RDDT: use brute force knowhere - #32

Merged
c-i-njoroge merged 3 commits into
reddit/v2.6.18from
charles-njoroge/brute-force-knowhere
Aug 12, 2026
Merged

RDDT: use brute force knowhere#32
c-i-njoroge merged 3 commits into
reddit/v2.6.18from
charles-njoroge/brute-force-knowhere

Conversation

@c-i-njoroge

@c-i-njoroge c-i-njoroge commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Closes #

💸 TL;DR

Using new tag with knowhere brute force enabled

📜 Details

Design Doc

Jira

🧪 Testing Steps / Validation

✅ Checks

  • CI tests (if present) are passing
  • Adheres to code style for repo
  • Contributor License Agreement (CLA) completed if not a Reddit employee

update knowhere version

change branch

increase milvus common version
@c-i-njoroge
c-i-njoroge force-pushed the charles-njoroge/brute-force-knowhere branch from b6f8e2b to d9f9865 Compare August 8, 2026 02:25
@c-i-njoroge
c-i-njoroge marked this pull request as ready for review August 12, 2026 02:30
@hicder-rddt

Copy link
Copy Markdown
Collaborator

make sure you update the commit tile to have RDDT: prefix so we can distinguish that this commit comes from Reddit

@c-i-njoroge c-i-njoroge changed the title Charles njoroge/brute force knowhere RDDT: brute force knowhere Aug 12, 2026
@c-i-njoroge c-i-njoroge changed the title RDDT: brute force knowhere RDDT: use brute force knowhere Aug 12, 2026
@c-i-njoroge
c-i-njoroge merged commit bf1d05b into reddit/v2.6.18 Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants