fix(membership): remove managing member type per 2024 bylaws change (#2916)

Closes #2566

Co-authored-by: Dorian Adams <dorian-adams@users.noreply.github.com>
Co-authored-by: jacob <jacob@coffee.dev>

Author: 3 people

apps/users/actions.py

@@ -7,7 +7,7 @@
 
 def export_csv(modeladmin, request, queryset):
     """Export selected memberships as a CSV file."""
-    membership_name = {0: "Basic", 1: "Supporting", 2: "Sponsor", 3: "Managing", 4: "Contributing", 5: "Fellow"}
+    membership_name = {0: "Basic", 1: "Supporting", 2: "Sponsor", 4: "Contributing", 5: "Fellow"}
     response = HttpResponse(content_type="text/csv")
     response["Content-Disposition"] = "attachment; filename=membership.csv"
     fieldnames = [

apps/users/migrations/0016_merge_managing_into_contributing.py

@@ -0,0 +1,22 @@
+# Data migration: Merge MANAGING (3) membership_type into CONTRIBUTING (4)
+# Per 2024 PSF Bylaws Change 1 (https://github.com/psf/bylaws/pull/4)
+
+from django.db import migrations
+
+
+def merge_managing_into_contributing(apps, schema_editor):
+    Membership = apps.get_model("users", "Membership")
+    Membership.objects.filter(membership_type=3).update(membership_type=4)
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("users", "0015_alter_user_first_name"),
+    ]
+
+    operations = [
+        migrations.RunPython(
+            merge_managing_into_contributing,
+            migrations.RunPython.noop,
+        ),
+    ]

apps/users/migrations/0017_remove_managing_membership_type.py

@@ -0,0 +1,24 @@
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("users", "0016_merge_managing_into_contributing"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="membership",
+            name="membership_type",
+            field=models.IntegerField(
+                choices=[
+                    (0, "Basic Member"),
+                    (1, "Supporting Member"),
+                    (2, "Sponsor Member"),
+                    (4, "Contributing Member"),
+                    (5, "Fellow"),
+                ],
+                default=0,
+            ),
+        ),
+    ]

apps/users/models.py

@@ -91,15 +91,13 @@ class Membership(models.Model):
     BASIC = 0
     SUPPORTING = 1
     SPONSOR = 2
-    MANAGING = 3
     CONTRIBUTING = 4
     FELLOW = 5
 
     MEMBERSHIP_CHOICES = (
         (BASIC, "Basic Member"),
         (SUPPORTING, "Supporting Member"),
         (SPONSOR, "Sponsor Member"),
-        (MANAGING, "Managing Member"),
         (CONTRIBUTING, "Contributing Member"),
         (FELLOW, "Fellow"),
     )