Skip to content

Commit 97d5c32

Browse files
committed
update with bata's reasoning
1 parent f6ffcef commit 97d5c32

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

docs/add-symbol-file.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,12 +107,14 @@ mahaloz pointed out that GDB likes it when you pass in the ELF for the host mach
107107
And it all seems to work. So for now I am pinning the ELF to be x86_64 + ELFCLASS64 until we encounter an actual issue.
108108

109109

110-
## Bata's code is weird
110+
## Bata's design decisions
111111

112112
He actually passes an address to `add-symbol-file`. I see no actual benefit to doing this.
113113

114114
Also he keeps .data and .bss but none of the symbols reference them.
115115

116+
Read his reasoning here: https://github.com/pwndbg/niche-elf/issues/5 . Using relative offsets and passing an `ADDR` allows him to reuse (i.e. not have to regenerate) the same ELF for different KASLR runs.
117+
116118
## Design choices
117119

118120
### Passing an address

0 commit comments

Comments
 (0)