Remove special lock handling for distributions

The base_path integrity is maintained by a database constraint now.

Author: mdellweg

pulpcore/app/viewsets/base.py

@@ -429,27 +429,20 @@ def async_reserved_resources(self, instance, **kwargs):
 
         This default implementation locks the instance being worked on.
 
-        .. note::
-
-          This does not work for [pulpcore.app.viewsets.AsyncCreateMixin][]
-          (as there is no instance). Classes using [pulpcore.app.viewsets.AsyncCreateMixin][]
-          must override this method.
-
         Args:
-            instance (django.models.Model): The instance that will be worked
+            instance (django.models.Model | None): The instance that will be worked
                 on by the task.
 
         Returns:
-            list/str: The resources to put in the task's reservation
+            list[django.models.Model | str]: The resources to put in the task's reservation
 
         Raises:
             AssertionError if instance is None (which happens for creation)
 
         """
-        assert instance is not None, (
-            "'{}' must not use the default `async_reserved_resources` method when using create."
-        ).format(self.__class__.__name__)
-        return [instance]
+        if instance is not None:
+            return [instance]
+        return []
 
     def async_shared_resources(self, instance, **kwargs):
         """
@@ -460,7 +453,7 @@ def async_shared_resources(self, instance, **kwargs):
         return []
 
 
-class AsyncCreateMixin:
+class AsyncCreateMixin(AsyncReservedObjectMixin):
     """
     Provides a create method that dispatches a task with reservation.
     """

pulpcore/app/viewsets/publication.py

@@ -526,34 +526,6 @@ def get_queryset(self):
             )
         return qs
 
-    def async_reserved_resources(self, instance):
-        """
-        Reserve safe distribution locks for async operations.
-
-        The explicit distribution.base_path lock protects the domain-wide base_path invariant.
-        The older domain-scoped distributions lock remains shared so tasks queued before an upgrade
-        still overlap safely with new tasks.
-        """
-        distribution_base_path = f"pdrn:{get_domain().pulp_id}:distribution.base_path"
-        if instance is None:
-            return [distribution_base_path]
-
-        if getattr(self, "action", "") == "destroy":
-            return [instance]
-
-        request_data = getattr(getattr(self, "request", None), "data", {})
-        requested_base_path = request_data.get("base_path", instance.base_path)
-        if requested_base_path == instance.base_path:
-            return [instance]
-
-        return [instance, distribution_base_path]
-
-    def async_shared_resources(self, instance):
-        """
-        Keep the legacy domain-scoped distribution lock shared for upgrade compatibility.
-        """
-        return [f"pdrn:{get_domain().pulp_id}:distributions"]
-
 
 class ListDistributionViewSet(BaseDistributionViewSet, mixins.ListModelMixin):
     DEFAULT_ACCESS_POLICY = {