fix(rx-schema): clean up indexes in getJsonSchemaWithoutMeta() (#8325)

getJsonSchemaWithoutMeta() removed internal meta properties (_deleted,
_rev, _meta, _attachments) from properties and required but left their
references in the indexes array, producing an internally inconsistent
schema. Now also filters _-prefixed fields from indexes and removes
empty indexes.

https://claude.ai/code/session_01JzvzrsJQH7Yp3BYqWRSQHf

Co-authored-by: Claude <noreply@anthropic.com>

Author: pubkey

orga/changelog/fix-getjsonschemawithoutmeta-indexes.md

@@ -0,0 +1 @@
+- FIX `getJsonSchemaWithoutMeta()` not removing internal meta field references (`_deleted`, `_meta.lwt`) from indexes, while correctly removing them from properties and required, causing the returned schema to be internally inconsistent

src/rx-schema.ts

@@ -86,6 +86,16 @@ export class RxSchema<RxDocType = any> {
             jsonSchema.required = jsonSchema.required.filter((r: string) => !r.startsWith('_'));
         }
 
+        // remove internal meta fields from indexes, consistent with properties and required cleanup
+        if (jsonSchema.indexes) {
+            jsonSchema.indexes = jsonSchema.indexes
+                .map((index: string | string[]) => {
+                    const arr: string[] = isMaybeReadonlyArray(index) ? [...index] : [index];
+                    return arr.filter((field: string) => !field.startsWith('_'));
+                })
+                .filter((index: string[]) => index.length > 0);
+        }
+
         return jsonSchema as RxJsonSchema<RxDocumentData<RxDocType>>;
     }
 

test/unit/rx-schema.test.ts

@@ -1477,6 +1477,38 @@ describeParallel('rx-schema.test.ts', () => {
             assert.ok(propertyKeys.includes('passportId'));
             assert.ok(propertyKeys.includes('age'));
 
+            await db.close();
+        });
+        it('indexes should not reference internal meta fields that are removed from properties', async () => {
+            const db = await createRxDatabase({
+                name: randomToken(10),
+                storage: config.storage.getStorage()
+            });
+            const collections = await db.addCollections({
+                humans: {
+                    schema: schemas.human
+                }
+            });
+            const schemaWithoutMeta = collections.humans.schema.getJsonSchemaWithoutMeta();
+            const propertyKeys = Object.keys(schemaWithoutMeta.properties);
+
+            // every field referenced in an index must exist in properties
+            const indexes = schemaWithoutMeta.indexes as string[][];
+            for (const index of indexes) {
+                const fields = Array.isArray(index) ? index : [index];
+                for (const field of fields) {
+                    const topLevelField = field.split('.')[0];
+                    assert.ok(
+                        propertyKeys.includes(topLevelField),
+                        'index field "' + field + '" references property "' + topLevelField + '" which does not exist in the schema returned by getJsonSchemaWithoutMeta()'
+                    );
+                }
+            }
+
+            // user-defined index fields should still be present
+            const allIndexFields = indexes.flat();
+            assert.ok(allIndexFields.includes('firstName'), 'user-defined index field "firstName" should be present');
+
             await db.close();
         });
     });