Skip to content

Synchronize common files from prometheus/prometheus - #5458

Merged
SoloJacobs merged 1 commit into
prometheus:mainfrom
prombot:repo_sync
Aug 19, 2026
Merged

Synchronize common files from prometheus/prometheus#5458
SoloJacobs merged 1 commit into
prometheus:mainfrom
prombot:repo_sync

Conversation

@prombot

@prombot prombot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Propagating changes from prometheus/prometheus default branch.

Source can be found here.

To check out this branch locally and push changes back:

git remote add prombot https://github.com/prombot/prometheus_alertmanager.git
git fetch prombot repo_sync
git checkout -b repo_sync prombot/repo_sync

Signed-off-by: prombot <prometheus-team@googlegroups.com>
@prombot
prombot requested a review from a team as a code owner August 18, 2026 17:54
@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 521fa400-2283-4f5e-86f1-78e55bccb7d3

📥 Commits

Reviewing files that changed from the base of the PR and between ee6b5f4 and bee83eb.

📒 Files selected for processing (1)
  • Makefile.common

Included review availability: Your plan includes up to 8 reviews per rolling hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

Docker builds now convert Prometheus architecture names to OCI platform strings. The computed platform is passed to both default and named Dockerfile builds. ARM architectures include their version.

Changes

Docker platform mapping

Layer / File(s) Summary
Platform conversion and build wiring
Makefile.common
DOCKER_ARCHS is documented as using Prometheus architecture names. ARM architectures convert to linux/arm/vN; other architectures convert to linux/<arch>. Docker builds receive the computed platform for default and named variants.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to bee83

This localized synchronization change introduces no actionable merge-blocking risk, so it is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the synchronization source but omits the required checklist responses and release-notes entry. Complete the template checklist and add a release-notes entry, using NONE if no user-facing changes apply.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the synchronization of common files from prometheus/prometheus.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@SoloJacobs
SoloJacobs merged commit bf3af85 into prometheus:main Aug 19, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants