Skip to content

Track eslint-plugin-react-hooks ESLint 10 peer dep support to remove legacy-peer-deps #28330

Description

@adkharat

Background

PR #28305 upgraded ESLint to v10 in presto-ui. During this upgrade, eslint-plugin-react-hooks was found to not yet declare ESLint 10 in its peer dependency range (though it works correctly at runtime).

As a workaround, .npmrc was added with legacy-peer-deps=true to allow npm install to succeed:

presto-ui/src/.npmrc

Task

Monitor the eslint-plugin-react-hooks release notes/changelog for an update that adds ESLint 10 to its peer dependency range.

Relevant upstream: https://github.com/facebook/react/tree/main/packages/eslint-plugin-react-hooks

Once they publish a release with ESLint 10 peer dep support, upgrade eslint-plugin-react-hooks in presto-ui/src/package.json and remove the legacy-peer-deps=true line from presto-ui/src/.npmrc (or delete the .npmrc entirely if it has no other entries).

References

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions