Skip to content

Commit bb292e8

Browse files
committed
ci: skip electron/chromium downloads in rebuild and bound the step
npm rebuild ran every dependency install script with output hidden; on a cold cache the electron (242MB) and chromium (~170MB) binary downloads could stall without a timeout and hang the job for hours. Tests only use webkit, which the playwright install step still provides.
1 parent b2fa19c commit bb292e8

1 file changed

Lines changed: 9 additions & 2 deletions

File tree

.github/workflows/pull-request.yml

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,19 @@ jobs:
3030
run: npm ci --ignore-scripts --no-audit --no-fund
3131

3232
# `npm rebuild` will run all those post-install scripts for us.
33+
# Skip the electron (242MB) and chromium (~170MB) binary downloads: tests only
34+
# use webkit, installed below. Without timeouts a stalled download hangs the
35+
# job silently for hours.
3336
- name: Rebuild
3437
shell: bash
35-
run: npm rebuild
38+
run: npm rebuild --foreground-scripts
39+
timeout-minutes: 15
40+
env:
41+
ELECTRON_SKIP_BINARY_DOWNLOAD: 1
42+
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: 1
3643

3744
- name: Install Playwright Browsers
38-
run: npx playwright install --with-deps
45+
run: npx playwright install --with-deps webkit
3946

4047
- name: Run Unit Tests
4148
run: npm run test

0 commit comments

Comments
 (0)