From f7af7a2d8c01476aaf3f8519479c25b0646d9e66 Mon Sep 17 00:00:00 2001
From: daniel-blom <38132380+daniel-blom@users.noreply.github.com>
Date: Fri, 6 Apr 2018 14:31:04 +0200
Subject: [PATCH] Fetch other formats when error

Do not skip gqx, tcx and fit files only because json_details does not exist.
---
 garminexport/backup.py | 23 +++++++++++++++--------
 1 file changed, 15 insertions(+), 8 deletions(-)

diff --git a/garminexport/backup.py b/garminexport/backup.py
index 18b49ee6..faf2e706 100644
--- a/garminexport/backup.py
+++ b/garminexport/backup.py
@@ -127,14 +127,21 @@ def download(client, activity, retryer, backup_dir, export_formats=None):
             f.write(json.dumps(
                 activity_summary, ensure_ascii=False, indent=4))
 
-    if 'json_details' in export_formats:
-        log.debug("getting json details for %s", id)
-        activity_details = retryer.call(client.get_activity_details, id)
-        dest = os.path.join(
-            backup_dir, export_filename(activity, 'json_details'))
-        with codecs.open(dest, encoding="utf-8", mode="w") as f:
-            f.write(json.dumps(
-                activity_details, ensure_ascii=False, indent=4))
+     if 'json_details' in export_formats:
+         log.debug("getting json details for %s", id)
+         """Do not skip gqx, tcx and fit files only because
+            json_details does not exist.
+         """
+         try:
+             activity_details = retryer.call(client.get_activity_details, id)
+             dest = os.path.join(
+                 backup_dir, export_filename(activity, 'json_details'))
+             with codecs.open(dest, encoding="utf-8", mode="w") as f:
+                 f.write(json.dumps(
+                     activity_details, ensure_ascii=False, indent=4))
+         except Exception as e:
+             log.error(u"failed with exception: %s", e)
+
 
     not_found_path = os.path.join(backup_dir, not_found_file)
     with open(not_found_path, mode="a") as not_found: