From cc1ecc5c86f97d93440b097ee6840a1ca62e021e Mon Sep 17 00:00:00 2001 From: Bec White Date: Wed, 22 Aug 2018 19:01:41 -0500 Subject: [PATCH 1/9] Add styleguide build command. --- tasks/styleguide.xml | 102 +++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 102 insertions(+) create mode 100644 tasks/styleguide.xml diff --git a/tasks/styleguide.xml b/tasks/styleguide.xml new file mode 100644 index 00000000..fc38ee79 --- /dev/null +++ b/tasks/styleguide.xml @@ -0,0 +1,102 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + Running build command in ${styleguide.root}: ${styleguide.command} + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + From 23af2c019d0ff4a10589aa20a59cdc99bdcef7cb Mon Sep 17 00:00:00 2001 From: Bec White Date: Wed, 22 Aug 2018 19:15:11 -0500 Subject: [PATCH 2/9] Add the styleguide target to the template build.xml file, and include the configuration task in the install process. --- build.dist.xml | 1 + tasks/install.xml | 1 + 2 files changed, 2 insertions(+) diff --git a/build.dist.xml b/build.dist.xml index 04ee5adf..975521e8 100644 --- a/build.dist.xml +++ b/build.dist.xml @@ -9,6 +9,7 @@ + diff --git a/tasks/install.xml b/tasks/install.xml index 9e179925..82fe5493 100644 --- a/tasks/install.xml +++ b/tasks/install.xml @@ -61,6 +61,7 @@ + From 686a08a290cb6c1e1679e897cf3b809b41413fdb Mon Sep 17 00:00:00 2001 From: Bec White Date: Wed, 22 Aug 2018 19:24:34 -0500 Subject: [PATCH 3/9] Run the styleguide build as part of the default build tasks. --- build.dist.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/build.dist.xml b/build.dist.xml index 975521e8..5e548143 100644 --- a/build.dist.xml +++ b/build.dist.xml @@ -15,6 +15,7 @@ + From 47dfa07115b1a299b719ebb7f2843d579f73a388 Mon Sep 17 00:00:00 2001 From: Bec White Date: Wed, 22 Aug 2018 19:25:01 -0500 Subject: [PATCH 4/9] Run yarn install in non-interactive mode. --- tasks/styleguide.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tasks/styleguide.xml b/tasks/styleguide.xml index fc38ee79..6b910d63 100644 --- a/tasks/styleguide.xml +++ b/tasks/styleguide.xml @@ -82,7 +82,7 @@ - + From eeb45d5431a4021b5afcab9d1c93337065adae9e Mon Sep 17 00:00:00 2001 From: Bec White Date: Wed, 22 Aug 2018 19:26:14 -0500 Subject: [PATCH 5/9] Add a todo for npm -- should we even support npm this way? --- tasks/styleguide.xml | 1 + 1 file changed, 1 insertion(+) diff --git a/tasks/styleguide.xml b/tasks/styleguide.xml index 6b910d63..38010f04 100644 --- a/tasks/styleguide.xml +++ b/tasks/styleguide.xml @@ -87,6 +87,7 @@ + From 9c03f311fa3a3624d8f603b22ca53cd69758ff2a Mon Sep 17 00:00:00 2001 From: Bec White Date: Wed, 22 Aug 2018 19:31:27 -0500 Subject: [PATCH 6/9] Don't support npm only right now. --- tasks/styleguide.xml | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/tasks/styleguide.xml b/tasks/styleguide.xml index 38010f04..e16bb568 100644 --- a/tasks/styleguide.xml +++ b/tasks/styleguide.xml @@ -85,18 +85,6 @@ - - - - - - - - - - - - From 2aea62ba417903ac45b43f5bba3d1b4b62842e76 Mon Sep 17 00:00:00 2001 From: Bec White Date: Wed, 22 Aug 2018 19:39:04 -0500 Subject: [PATCH 7/9] Add documentation on style guide configuration properties. --- docs/properties.md | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/docs/properties.md b/docs/properties.md index 095eb5b9..2d2ac56a 100644 --- a/docs/properties.md +++ b/docs/properties.md @@ -62,6 +62,15 @@ Cool! This phing-ism is what powers our environment-specific property layering a [More info](../tasks/drupal.xml#L16-L38) +### Style Guide + +| Property | Default value | What is it? | +|---|---|---| +| `styleguide.root` | `styleguide` | Location of the style guide, relative to the project root. | +| `styleguide.command` | `yarn default` | Command to compile the style guide assets, for use during the build and artifact steps. | + +[More info](../tasks/styleguide.xml#L22-L24) + ### Code Review | Property | Default value | What is it? | From 702c67d470a8ab19a89ab031ac443a434af8151c Mon Sep 17 00:00:00 2001 From: Bec White Date: Tue, 16 Oct 2018 16:29:31 -0500 Subject: [PATCH 8/9] Build the styleguide before running the drupal-build, and include an example call. --- build.dist.xml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/build.dist.xml b/build.dist.xml index 5e548143..c32c0c42 100644 --- a/build.dist.xml +++ b/build.dist.xml @@ -14,8 +14,11 @@ - + + + From b25d333e3a57b5ba1a6e0886d107588c5da9d358 Mon Sep 17 00:00:00 2001 From: byrond Date: Thu, 1 Nov 2018 16:18:36 -0400 Subject: [PATCH 9/9] run yarn install if node-sass binding for linux is missing --- tasks/styleguide.xml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tasks/styleguide.xml b/tasks/styleguide.xml index e16bb568..ccd2e649 100644 --- a/tasks/styleguide.xml +++ b/tasks/styleguide.xml @@ -79,7 +79,10 @@ - + + + +