Direct user to firewall rules tab from instance networking view#3216
Open
charliepark wants to merge 1 commit into
Open
Direct user to firewall rules tab from instance networking view#3216charliepark wants to merge 1 commit into
charliepark wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
charliepark
changed the title
Contributor
|
This is perhaps a misappropriation of the message box. Let me noodle on this further. |
Collaborator
|
Another option, like what Charlie did in #2064 (comment), but with a title on the card block. 
|
Contributor
|
Is an instance only affected by firewall rules on one (the primary) VPC? |
Collaborator
|
I think any of them can affect the instance, but I'm not 100% sure. Most of the time there will only be one anyway, so in theory we could detect that and phrase it accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a message box — directing the user to the Firewall Rules tab of the VPC — to the instance's Networking tab.
When there are multiple VPCs:
I'm very open to alternate designs and copy.
Closes #2064