Refactor PkgConfig#30
Merged
Merged
Conversation
doudou
force-pushed
the
refactor_pkgconfig
branch
from
eff69af to
4094a65
Compare
This was referenced Apr 18, 2016
doudou
force-pushed
the
refactor_pkgconfig
branch
2 times, most recently
from
b8ef48b to
713e58c
Compare
Merged
doudou
force-pushed
the
refactor_pkgconfig
branch
from
713e58c to
3c9fea2
Compare
…int name to compute a total duration
The cache was a workaround for the badness of the way orogen was loading packages. Now that this is fixed, it does more harm than good since the pkgconfig objects end in the long-lived objects (something that can end up being up to 50k objects ...)
doudou
force-pushed
the
refactor_pkgconfig
branch
from
3c9fea2 to
153e0a6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apart from two minor changes, this suite of commits is mainly about removing the cache in Utilrb::PkgConfig, and giving more flexibility when loading the pkg-config information.
The goal is here is to give a choice. In e.g. orogen, one needs to resolve all the cflags and friends. In orocos.rb/Syskit, we're only interested in getting the variables, which is much MUCH simpler to load.
Also closes #29