Skip to content

Misleading by-ref indirection in UserManager::hashPassword #9

Description

@kojiromike

In UserManager::hashPassword (src/Service/UserManager.php:233-234), $passwordRef = $password; is a value copy whose only purpose is to satisfy AuthHash::passwordHash's by-reference signature. The variable name and surrounding comment imply it preserves something it does not.

Rename to $mutable (or similar) and adjust the comment so the next maintainer understands this is just a by-ref-signature workaround, not a meaningful indirection.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions