fixed errors

Author: wrisa

instrumentation-genai/opentelemetry-instrumentation-langchain/examples/workflow/main.py

@@ -8,7 +8,6 @@
 
 from typing import Annotated
 
-
 from langchain_core.messages import HumanMessage, SystemMessage
 from langchain_openai import ChatOpenAI
 from langgraph.graph import END, START, StateGraph
@@ -33,7 +32,6 @@
 from opentelemetry.sdk.trace import TracerProvider
 from opentelemetry.sdk.trace.export import BatchSpanProcessor
 
-
 # Configure tracing
 trace.set_tracer_provider(TracerProvider())
 span_processor = BatchSpanProcessor(OTLPSpanExporter())
@@ -112,4 +110,4 @@ def main():
 
 
 if __name__ == "__main__":
-    main()
+    main()

instrumentation-genai/opentelemetry-instrumentation-langchain/src/opentelemetry/instrumentation/langchain/callback_handler.py

@@ -25,8 +25,10 @@
     _InvocationManager,
 )
 from opentelemetry.util.genai.handler import TelemetryHandler
-from opentelemetry.util.genai.invocation import InferenceInvocation
-from opentelemetry.util.genai.invocation import WorkflowInvocation
+from opentelemetry.util.genai.invocation import (
+    InferenceInvocation,
+    WorkflowInvocation,
+)
 from opentelemetry.util.genai.types import (
     InputMessage,
     MessagePart,
@@ -58,21 +60,26 @@ def on_chain_start(
     ) -> Any:
         payload = serialized or {}
         name_source = (
-                payload.get("name")
-                or payload.get("id")
-                or kwargs.get("name")
-                or (metadata.get("langgraph_node") if metadata else None)
+            payload.get("name")
+            or payload.get("id")
+            or kwargs.get("name")
+            or (metadata.get("langgraph_node") if metadata else None)
         )
         name = str(name_source or "chain")
 
         if parent_run_id is None:
-            workflow_name_override = metadata.get("workflow_name") if metadata else None
-            wf = self._telemetry_handler.start_workflow(name=workflow_name_override or name)
+            workflow_name_override = (
+                metadata.get("workflow_name") if metadata else None
+            )
+            wf = self._telemetry_handler.start_workflow(
+                name=workflow_name_override or name
+            )
             self._invocation_manager.add_invocation_state(run_id, None, wf)
             return
         else:
-            self._invocation_manager.add_invocation_state(run_id, parent_run_id)
-
+            self._invocation_manager.add_invocation_state(
+                run_id, parent_run_id
+            )
 
     def on_chain_end(
         self,
@@ -94,7 +101,6 @@ def on_chain_end(
         if not invocation.span.is_recording():
             self._invocation_manager.delete_invocation_state(run_id)
 
-
     def on_chain_error(
         self,
         error: BaseException,
@@ -336,4 +342,3 @@ def on_llm_error(
         llm_invocation.fail(error)
         if not llm_invocation.span.is_recording():
             self._invocation_manager.delete_invocation_state(run_id=run_id)
-

instrumentation-genai/opentelemetry-instrumentation-langchain/tests/test_workflow_chain.py

@@ -43,11 +43,10 @@
 from unittest import TestCase
 from unittest.mock import patch
 
-from langchain_core.outputs import ChatGeneration, LLMResult
 from langchain_core.messages import AIMessage
+from langchain_core.outputs import ChatGeneration, LLMResult
 
 from opentelemetry import baggage
-from opentelemetry import context as otel_context
 from opentelemetry.instrumentation.langchain.callback_handler import (
     OpenTelemetryLangChainCallbackHandler,
 )
@@ -63,11 +62,11 @@
 )
 from opentelemetry.util.genai.handler import TelemetryHandler
 
-
 # ---------------------------------------------------------------------------
 # Shared helpers
 # ---------------------------------------------------------------------------
 
+
 def _make_serialized(name: str) -> dict:
     """Minimal serialized dict that on_chain_start / on_chat_model_start expect."""
     return {"name": name}
@@ -78,18 +77,26 @@ def _make_llm_result(content: str = "hello") -> LLMResult:
     msg = AIMessage(content=content)
     gen = ChatGeneration(message=msg, text=content)
     gen.generation_info = {"finish_reason": "stop"}
-    return LLMResult(generations=[[gen]], llm_output={"model_name": "gpt-3.5-turbo"})
+    return LLMResult(
+        generations=[[gen]], llm_output={"model_name": "gpt-3.5-turbo"}
+    )
 
 
 def _make_chat_invocation_params(model_name: str = "gpt-3.5-turbo") -> dict:
     """kwargs dict that on_chat_model_start receives for a ChatOpenAI call."""
-    return {"invocation_params": {"model_name": model_name, "params": {"model_name": model_name}}}
+    return {
+        "invocation_params": {
+            "model_name": model_name,
+            "params": {"model_name": model_name},
+        }
+    }
 
 
 # ---------------------------------------------------------------------------
 # Base test class
 # ---------------------------------------------------------------------------
 
+
 class _CallbackHandlerTestBase(TestCase):
     def setUp(self) -> None:
         self.span_exporter = InMemorySpanExporter()
@@ -113,6 +120,7 @@ def _spans_by_kind(self, kind: SpanKind):
 # Tests
 # ---------------------------------------------------------------------------
 
+
 class TestWorkflowSpanCreation(_CallbackHandlerTestBase):
     """Verify that a workflow span is created for top-level chains."""
 
@@ -243,7 +251,9 @@ def test_workflow_name_from_metadata_override(self) -> None:
 
         internal_spans = self._spans_by_kind(SpanKind.INTERNAL)
         self.assertEqual(len(internal_spans), 1)
-        self.assertEqual(internal_spans[0].name, "invoke_workflow my_custom_wf")
+        self.assertEqual(
+            internal_spans[0].name, "invoke_workflow my_custom_wf"
+        )
 
         client_spans = self._spans_by_kind(SpanKind.CLIENT)
         self.assertEqual(len(client_spans), 1)
@@ -257,7 +267,11 @@ class TestCSANotLeakedToBaggage(_CallbackHandlerTestBase):
     """Verify that gen_ai.workflow.name is NOT written to W3C Baggage by default."""
 
     def test_csa_not_leaked_to_baggage(self) -> None:
-        env = {k: v for k, v in os.environ.items() if k != "OTEL_PYTHON_GENAI_CAPTURE_BAGGAGE"}
+        env = {
+            k: v
+            for k, v in os.environ.items()
+            if k != "OTEL_PYTHON_GENAI_CAPTURE_BAGGAGE"
+        }
         with patch.dict(os.environ, env, clear=True):
             chain_run_id = uuid.uuid4()
 
@@ -458,9 +472,13 @@ def test_llm_error_inside_workflow_records_error_on_llm_span(self) -> None:
         # Workflow span still finishes (not in error state)
         internal_spans = self._spans_by_kind(SpanKind.INTERNAL)
         self.assertEqual(len(internal_spans), 1)
-        self.assertNotEqual(internal_spans[0].status.status_code, StatusCode.ERROR)
+        self.assertNotEqual(
+            internal_spans[0].status.status_code, StatusCode.ERROR
+        )
 
-    def test_llm_error_inside_workflow_llm_span_is_child_of_workflow(self) -> None:
+    def test_llm_error_inside_workflow_llm_span_is_child_of_workflow(
+        self,
+    ) -> None:
         chain_run_id = uuid.uuid4()
         llm_run_id = uuid.uuid4()
 
@@ -520,7 +538,9 @@ def test_name_falls_back_to_id_list(self) -> None:
             run_id=chain_run_id,
             parent_run_id=None,
         )
-        self.handler.on_chain_end(outputs={}, run_id=chain_run_id, parent_run_id=None)
+        self.handler.on_chain_end(
+            outputs={}, run_id=chain_run_id, parent_run_id=None
+        )
 
         internal_spans = self._spans_by_kind(SpanKind.INTERNAL)
         self.assertEqual(len(internal_spans), 1)
@@ -537,7 +557,9 @@ def test_name_falls_back_to_langgraph_node(self) -> None:
             parent_run_id=None,
             metadata={"langgraph_node": "my_node"},
         )
-        self.handler.on_chain_end(outputs={}, run_id=chain_run_id, parent_run_id=None)
+        self.handler.on_chain_end(
+            outputs={}, run_id=chain_run_id, parent_run_id=None
+        )
 
         internal_spans = self._spans_by_kind(SpanKind.INTERNAL)
         self.assertEqual(len(internal_spans), 1)
@@ -552,7 +574,9 @@ def test_name_defaults_to_chain_when_nothing_provided(self) -> None:
             run_id=chain_run_id,
             parent_run_id=None,
         )
-        self.handler.on_chain_end(outputs={}, run_id=chain_run_id, parent_run_id=None)
+        self.handler.on_chain_end(
+            outputs={}, run_id=chain_run_id, parent_run_id=None
+        )
 
         internal_spans = self._spans_by_kind(SpanKind.INTERNAL)
         self.assertEqual(len(internal_spans), 1)