test(sqlite3): add uninstrument, error status, suppress, and no-op tests (#4335)

* test(sqlite3): add uninstrument, error, suppress, and no-op tests

Signed-off-by: Artem Muterko <artem@sopho.tech>
Signed-off-by: Artem Muterko <artieua@gmail.com>

* test(sqlite3): address review feedback and add CHANGELOG

- Add _connect helper with addCleanup for proper resource teardown
- Rename test_uninstrument_connection to test_uninstrument_connection_with_instrument for consistency with psycopg2
- Use same query before and after uninstrumenting
- Clear memory exporter and assert zero spans after uninstrument
- Use sqlite3.OperationalError instead of generic Exception
- Add span.status.description assertion for error test
- Add CHANGELOG entry

Signed-off-by: Artem Muterko <artem@sopho.tech>
Signed-off-by: Artem Muterko <artieua@gmail.com>

* test(sqlite3): add additional tests

Signed-off-by: Artem Muterko <artem@sopho.tech>
Signed-off-by: Artem Muterko <artieua@gmail.com>

* Update CHANGELOG.md

---------

Signed-off-by: Artem Muterko <artem@sopho.tech>
Signed-off-by: Artem Muterko <artieua@gmail.com>
Co-authored-by: Tammy Baylis <96076570+tammy-baylis-swi@users.noreply.github.com>
Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>

Author: 3 people

CHANGELOG.md

@@ -15,6 +15,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Bump `pylint` to `4.0.5`
   ([#4244](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/4244))
+- `opentelemetry-instrumentation-sqlite3`: Add uninstrument, error status, suppress, and no-op tests
+  ([#4335](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/4335))
 
 ### Fixed
 

instrumentation/opentelemetry-instrumentation-sqlite3/tests/test_sqlite3.py

@@ -17,6 +17,10 @@
 
 from opentelemetry import trace as trace_api
 from opentelemetry.instrumentation.sqlite3 import SQLite3Instrumentor
+from opentelemetry.instrumentation.utils import suppress_instrumentation
+from opentelemetry.semconv._incubating.attributes.db_attributes import (
+    DB_STATEMENT,
+)
 from opentelemetry.test.test_base import TestBase
 
 
@@ -120,3 +124,107 @@ def test_callproc(self):
         ):
             self._cursor.callproc("test", ())
             self.validate_spans("test")
+
+
+class TestSQLite3Integration(TestBase):
+    def tearDown(self):
+        super().tearDown()
+        SQLite3Instrumentor().uninstrument()
+
+    def _connect(self):
+        """Create an in-memory connection with cleanup registered."""
+        cnx = sqlite3.connect(":memory:")
+        self.addCleanup(cnx.close)
+        return cnx
+
+    def test_uninstrument(self):
+        """Should stop generating spans after uninstrument."""
+        SQLite3Instrumentor().instrument(tracer_provider=self.tracer_provider)
+        cnx = self._connect()
+        cursor = cnx.cursor()
+        self.addCleanup(cursor.close)
+        cursor.execute("CREATE TABLE IF NOT EXISTS test (id integer)")
+
+        spans_list = self.memory_exporter.get_finished_spans()
+        self.assertEqual(len(spans_list), 1)
+
+        SQLite3Instrumentor().uninstrument()
+        self.memory_exporter.clear()
+
+        cnx2 = self._connect()
+        cursor2 = cnx2.cursor()
+        self.addCleanup(cursor2.close)
+        cursor2.execute("CREATE TABLE IF NOT EXISTS test (id integer)")
+
+        spans_list = self.memory_exporter.get_finished_spans()
+        self.assertEqual(len(spans_list), 0)
+
+    def test_uninstrument_connection_with_instrument(self):
+        """Should stop generating spans for uninstrumented connection."""
+        SQLite3Instrumentor().instrument(tracer_provider=self.tracer_provider)
+        cnx = self._connect()
+        query = "CREATE TABLE IF NOT EXISTS test (id integer)"
+        cursor = cnx.cursor()
+        self.addCleanup(cursor.close)
+        cursor.execute(query)
+
+        spans_list = self.memory_exporter.get_finished_spans()
+        self.assertEqual(len(spans_list), 1)
+
+        self.memory_exporter.clear()
+        cnx = SQLite3Instrumentor.uninstrument_connection(cnx)
+        cursor = cnx.cursor()
+        self.addCleanup(cursor.close)
+        cursor.execute(query)
+
+        spans_list = self.memory_exporter.get_finished_spans()
+        self.assertEqual(len(spans_list), 0)
+
+    def test_no_op_tracer_provider(self):
+        """Should produce no spans with NoOpTracerProvider."""
+        SQLite3Instrumentor().instrument(
+            tracer_provider=trace_api.NoOpTracerProvider()
+        )
+        cnx = self._connect()
+        cursor = cnx.cursor()
+        self.addCleanup(cursor.close)
+        cursor.execute("CREATE TABLE IF NOT EXISTS test (id integer)")
+
+        spans_list = self.memory_exporter.get_finished_spans()
+        self.assertEqual(len(spans_list), 0)
+
+    def test_suppress_instrumentation(self):
+        """Should produce no spans when suppressed."""
+        SQLite3Instrumentor().instrument(tracer_provider=self.tracer_provider)
+        cnx = self._connect()
+
+        with suppress_instrumentation():
+            cursor = cnx.cursor()
+            self.addCleanup(cursor.close)
+            cursor.execute("CREATE TABLE IF NOT EXISTS test (id integer)")
+
+        spans_list = self.memory_exporter.get_finished_spans()
+        self.assertEqual(len(spans_list), 0)
+
+    def test_span_failed(self):
+        """Should set error status on span when query fails."""
+        SQLite3Instrumentor().instrument(tracer_provider=self.tracer_provider)
+        cnx = self._connect()
+        cursor = cnx.cursor()
+        self.addCleanup(cursor.close)
+
+        with self.assertRaises(sqlite3.OperationalError):
+            cursor.execute("SELECT * FROM nonexistent_table")
+
+        spans_list = self.memory_exporter.get_finished_spans()
+        self.assertEqual(len(spans_list), 1)
+        span = spans_list[0]
+        self.assertEqual(
+            span.attributes[DB_STATEMENT],
+            "SELECT * FROM nonexistent_table",
+        )
+        self.assertIs(span.status.status_code, trace_api.StatusCode.ERROR)
+        self.assertEqual(
+            span.status.description,
+            "OperationalError: no such table: nonexistent_table",
+        )