refactor(DimensionalityTab): migrate table to core-ui Table component#27969
refactor(DimensionalityTab): migrate table to core-ui Table component#27969shah-harshit wants to merge 14 commits intomainfrom
Conversation
Replace Ant Design Table with react-aria-based Table from @openmetadata/ui-core-components. Removes antd ColumnsType, HelpCircle icon, and Tooltip imports in favour of Table.Head tooltip prop. Impact-score tooltip now rendered natively by Table.Head. Trans type error fixed via ComponentType cast. Select dimension dropdown styled to match date picker height (h-8/32px) and font-size xs. Refs: open-metadata/openmetadata-collate#3837
Extract nested ternary cell renderer into a switch-based renderCell function. Wrap dimensionTableColumns in useMemo([t]) to stabilize the array reference across renders.
51e4dd8 to
ba81bf0
Compare
Code Review ✅ Approved 8 resolved / 8 findingsDimensionalityTab refactor migrates the table to core-ui components and optimizes performance by memoizing columns and cell renderers. All readability, stability, and rendering issues identified during review have been addressed. ✅ 8 resolved✅ Quality: Deeply nested ternary chain in cell renderer hurts readability
✅ Performance: dimensionTableColumns recreated on every render
✅ Bug: Table.Row key is undefined when record.id is missing
✅ Performance: renderRow is not memoized, recreated every render
✅ Quality: Orphan CSS class 'failed-sample-data-column' has no definition
...and 3 more resolved from earlier reviews OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|



Summary
Tablewith core-uiTable(react-aria-components) inDimensionalityTabTest plan
🤖 Generated with Claude Code
Summary by Gitar
incidentManager.tsto locate rows using atrfilter instead of directtest-caseIDs.edit-ownerbutton before interacting with it.This will update automatically on new commits.