Skip to content

Commit 5926ce9

Browse files
committed
fix: keep the "No data" message simple
It actually only renders when there's no data at all in the chart, so the facet is not relevant after all. This will be simpler to manage anyway.
1 parent b1c387f commit 5926ce9

6 files changed

Lines changed: 7 additions & 7 deletions

File tree

i18n/locales/en.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,7 @@
298298
"download_file": "Download {fileType}",
299299
"toggle_annotator": "Toggle annotator",
300300
"legend_estimation": "Estimation",
301-
"no_data": "No {facet} data available",
301+
"no_data": "No data available",
302302
"y_axis_label": "{granularity} {facet}",
303303
"items": {
304304
"downloads": "Downloads"

i18n/locales/fr-FR.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,7 @@
360360
"download_file": "Télécharger {fileType}",
361361
"toggle_annotator": "Afficher/Masquer l'annotateur",
362362
"legend_estimation": "Estimation",
363-
"no_data": "Aucune donnée de {facet} disponible",
363+
"no_data": "Données non disponibles",
364364
"y_axis_label": "{facet} {granularity}",
365365
"items": {
366366
"downloads": "Téléchargements"

lunaria/files/en-GB.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,7 @@
298298
"download_file": "Download {fileType}",
299299
"toggle_annotator": "Toggle annotator",
300300
"legend_estimation": "Estimation",
301-
"no_data": "No {facet} data available",
301+
"no_data": "No data available",
302302
"y_axis_label": "{granularity} {facet}",
303303
"items": {
304304
"downloads": "Downloads"

lunaria/files/en-US.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,7 @@
298298
"download_file": "Download {fileType}",
299299
"toggle_annotator": "Toggle annotator",
300300
"legend_estimation": "Estimation",
301-
"no_data": "No {facet} data available",
301+
"no_data": "No data available",
302302
"y_axis_label": "{granularity} {facet}",
303303
"items": {
304304
"downloads": "Downloads"

lunaria/files/fr-FR.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -360,7 +360,7 @@
360360
"download_file": "Télécharger {fileType}",
361361
"toggle_annotator": "Afficher/Masquer l'annotateur",
362362
"legend_estimation": "Estimation",
363-
"no_data": "Aucune donnée de {facet} disponible",
363+
"no_data": "Données non disponibles",
364364
"y_axis_label": "{facet} {granularity}",
365365
"items": {
366366
"downloads": "Téléchargements"

test/nuxt/components/PackageWeeklyDownloadStats.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ describe('PackageWeeklyDownloadStats', () => {
4040
})
4141

4242
expect(component.text()).toContain('Weekly Downloads')
43-
expect(component.text()).toContain('No download data available')
43+
expect(component.text()).toContain('No data available')
4444
})
4545

4646
it('shows the section when weekly downloads exist', async () => {
@@ -60,6 +60,6 @@ describe('PackageWeeklyDownloadStats', () => {
6060
})
6161

6262
expect(component.text()).toContain('Weekly Downloads')
63-
expect(component.text()).not.toContain('No download data available')
63+
expect(component.text()).not.toContain('No data available')
6464
})
6565
})

0 commit comments

Comments
 (0)