lib,src: remove --no-experimental-websocket CLI flag

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

Author: aduh95

doc/api/cli.md

@@ -2139,14 +2139,6 @@ changes:
 
 Disable the experimental [`node:sqlite`][] module.
 
-### `--no-experimental-websocket`
-
-<!-- YAML
-added: v22.0.0
--->
-
-Disable exposition of {WebSocket} on the global scope.
-
 ### `--no-experimental-webstorage`
 
 <!-- YAML
@@ -3889,6 +3881,7 @@ one is included in the list below.
 * `--experimental-vfs`
 * `--experimental-vm-modules`
 * `--experimental-wasi-unstable-preview1`
+* `--experimental-websocket`
 * `--force-context-aware`
 * `--force-fips`
 * `--force-node-api-uncaught-exceptions-policy`
@@ -3919,7 +3912,6 @@ one is included in the list below.
 * `--no-experimental-global-navigator`
 * `--no-experimental-sqlite`
 * `--no-experimental-strip-types`
-* `--no-experimental-websocket`
 * `--no-experimental-webstorage`
 * `--no-extra-info-on-fatal-exception`
 * `--no-force-async-hooks-checks`

doc/api/globals.md

@@ -334,10 +334,12 @@ added: v0.0.1
 
 <!-- YAML
 added: v23.0.0
+  - version: REPLACEME
+    pr-url: TODO
+    description: No longer be disabled with `--no-experimental-websocket` CLI flag.
 -->
 
-A browser-compatible implementation of {CloseEvent}. Disable this API
-with the [`--no-experimental-websocket`][] CLI flag.
+A browser-compatible implementation of {CloseEvent}.
 
 ## Class: `CompressionStream`
 
@@ -1299,6 +1301,9 @@ added:
   - v21.0.0
   - v20.10.0
 changes:
+  - version: REPLACEME
+    pr-url: TODO
+    description: No longer be disabled with `--no-experimental-websocket` CLI flag.
   - version: v22.4.0
     pr-url: https://github.com/nodejs/node/pull/53352
     description: No longer experimental.
@@ -1307,8 +1312,7 @@ changes:
     description: No longer behind `--experimental-websocket` CLI flag.
 -->
 
-A browser-compatible implementation of {WebSocket}. Disable this API
-with the [`--no-experimental-websocket`][] CLI flag.
+A browser-compatible implementation of {WebSocket}.
 
 ## Class: `WritableStream`
 
@@ -1361,7 +1365,6 @@ A browser-compatible implementation of [`WritableStreamDefaultWriter`][].
 [`--experimental-eventsource`]: cli.md#--experimental-eventsource
 [`--localstorage-file`]: cli.md#--localstorage-filefile
 [`--no-experimental-global-navigator`]: cli.md#--no-experimental-global-navigator
-[`--no-experimental-websocket`]: cli.md#--no-experimental-websocket
 [`--no-experimental-webstorage`]: cli.md#--no-experimental-webstorage
 [`ByteLengthQueuingStrategy`]: webstreams.md#class-bytelengthqueuingstrategy
 [`CompressionStream`]: webstreams.md#class-compressionstream

doc/node.1

@@ -1107,9 +1107,6 @@ Legacy alias for \fB--no-require-module\fR.
 .It Fl -no-experimental-sqlite
 Disable the experimental \fBnode:sqlite\fR module.
 .
-.It Fl -no-experimental-websocket
-Disable exposition of \fB<WebSocket>\fR on the global scope.
-.
 .It Fl -no-experimental-webstorage
 Disable \fBWeb Storage\fR support.
 .
@@ -2022,6 +2019,8 @@ one is included in the list below.
 .It
 \fB--experimental-wasi-unstable-preview1\fR
 .It
+\fB--experimental-websocket\fR
+.It
 \fB--force-context-aware\fR
 .It
 \fB--force-fips\fR
@@ -2082,8 +2081,6 @@ one is included in the list below.
 .It
 \fB--no-experimental-strip-types\fR
 .It
-\fB--no-experimental-websocket\fR
-.It
 \fB--no-experimental-webstorage\fR
 .It
 \fB--no-extra-info-on-fatal-exception\fR

lib/internal/process/pre_execution.js

@@ -121,7 +121,6 @@ function prepareExecution(options) {
   setupVfs();
   setupQuic();
   setupWebStorage();
-  setupWebsocket();
   setupEventsource();
   setupCodeCoverage();
   setupDebugEnv();
@@ -352,14 +351,6 @@ function setupWarningHandler() {
   }
 }
 
-// https://websockets.spec.whatwg.org/
-function setupWebsocket() {
-  if (getOptionValue('--no-experimental-websocket')) {
-    delete globalThis.WebSocket;
-    delete globalThis.CloseEvent;
-  }
-}
-
 // https://html.spec.whatwg.org/multipage/server-sent-events.html
 function setupEventsource() {
   if (!getOptionValue('--experimental-eventsource')) {

src/node_options.cc

@@ -595,11 +595,7 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() {
             kAllowedInEnvvar,
             false);
 #endif  // HAVE_FFI
-  AddOption("--experimental-websocket",
-            "experimental WebSocket API",
-            BOOL_FIELD(experimental_websocket),
-            kAllowedInEnvvar,
-            true);
+  AddOption("--experimental-websocket", "", NoOp{}, kAllowedInEnvvar);
   AddOption("--experimental-global-customevent", "", NoOp{}, kAllowedInEnvvar);
   AddOption("--experimental-sqlite",
             "experimental node:sqlite module",