refactor: use node-mock-http instead of unenv v1 for local fetch (#3069)

Author: pi0

package.json

@@ -142,6 +142,7 @@
     "mime": "^4.0.6",
     "mlly": "^1.7.4",
     "node-fetch-native": "^1.6.6",
+    "node-mock-http": "^1.0.0",
     "ofetch": "^1.4.1",
     "ohash": "^1.1.4",
     "openapi-typescript": "^7.6.0",

pnpm-lock.yaml

@@ -17,12 +17,12 @@ import type {
   NitroRuntimeHooks,
 } from "nitropack/types";
 import type { NitroAsyncContext } from "nitropack/types";
-import type { $Fetch, NitroFetchRequest } from "nitropack/types";
 import { Headers, createFetch } from "ofetch";
 import {
-  createCall,
-  createFetch as createLocalFetch,
-} from "unenv/runtime/fetch/index";
+  fetchNodeRequestHandler,
+  callNodeRequestHandler,
+  type AbstractRequest,
+} from "node-mock-http";
 import errorHandler from "#nitro-internal-virtual/error-handler";
 import { plugins } from "#nitro-internal-virtual/plugins";
 import { handlers } from "#nitro-internal-virtual/server-handlers";
@@ -85,14 +85,20 @@ function createNitroApp(): NitroApp {
     preemptive: true,
   });
 
-  // Create local fetch callers
-  const localCall = createCall(toNodeListener(h3App) as any);
-  // prettier-ignore
-  const _localFetch = createLocalFetch(localCall, (u, i) => globalThis.fetch(u, i));
-  const localFetch: typeof fetch = (input, init) =>
-    _localFetch(input as RequestInfo, init as any).then((response) =>
-      normalizeFetchResponse(response)
-    );
+  // Create local fetch caller
+  const nodeHandler = toNodeListener(h3App);
+  const localCall = (aRequest: AbstractRequest) =>
+    callNodeRequestHandler(nodeHandler, aRequest);
+  const localFetch: typeof fetch = (input, init) => {
+    if (!input.toString().startsWith("/")) {
+      return globalThis.fetch(input, init);
+    }
+    return fetchNodeRequestHandler(
+      nodeHandler,
+      input as string /* TODO */,
+      init
+    ).then((response) => normalizeFetchResponse(response));
+  };
   const $fetch = createFetch({
     fetch: localFetch,
     Headers,

src/runtime/internal/app.ts

@@ -1,17 +1,17 @@
 import type { App as H3App, H3Event, Router } from "h3";
 import type { Hookable } from "hookable";
 import type { NitroRuntimeHooks as NitroTypesRuntimeHooks } from "nitropack";
-import type {
-  createCall,
-  createFetch as createLocalFetch,
-} from "unenv/runtime/fetch/index";
+import type { AbstractRequest, AbstractResponse } from "node-mock-http";
 
 export interface NitroApp {
   h3App: H3App;
   router: Router;
   hooks: Hookable<NitroRuntimeHooks>;
-  localCall: ReturnType<typeof createCall>;
-  localFetch: ReturnType<typeof createLocalFetch>;
+  localCall: (aRequest: AbstractRequest) => Promise<AbstractResponse>;
+  localFetch: (
+    req: string | URL | Request,
+    init?: RequestInit & AbstractRequest
+  ) => Promise<Response>;
   captureError: CaptureError;
 }
 

src/types/runtime/nitro.ts

@@ -0,0 +1,14 @@
+export default eventHandler(async (event) => {
+  const nitroApp = useNitroApp();
+  return {
+    $fetch: await fetch("/api/hey").then((r) => r.text()),
+    "event.fetch": await event.fetch("/api/hey").then((r) => r.text()),
+    "event.$fetch": await event.$fetch("/api/hey"),
+    "nitroApp.localFetch": await nitroApp
+      .localFetch("/api/hey")
+      .then((r) => r.text()),
+    "nitroApp.localCall": await nitroApp
+      .localCall({ url: "/api/hey" })
+      .then((r) => r.body),
+  };
+});