Skip to content

Commit 3089bfc

Browse files
authored
Remove implicit tsc flags (#4)
1 parent 57f7a33 commit 3089bfc

3 files changed

Lines changed: 2 additions & 38 deletions

File tree

ts-perf/packages/api/src/expansion.ts

Lines changed: 2 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -259,33 +259,10 @@ export class CommandLineArgumentsBuilder {
259259
}
260260

261261
addCompilerOptions(options: CompilerOptions, scenario: Scenario) {
262+
// TODO(jakebailey): This is a weird thing to do at this point;
263+
// only one caller needs this info and this should be moved there.
262264
this.hasBuild =
263265
-1 !== (scenario?.args ? Math.max(scenario.args.indexOf("-b"), scenario.args.indexOf("--build")) : -1);
264-
if (!this.hasBuild) {
265-
this.add(
266-
"--target",
267-
"es5",
268-
"--module",
269-
"amd",
270-
);
271-
if (scenario?.singleFileOutput) {
272-
this.add("--outfile", "${outDirectory}/out.js");
273-
}
274-
else {
275-
this.add("--outdir", "${outDirectory}");
276-
}
277-
if (options.full) {
278-
this.add(
279-
"--declaration",
280-
"--sourcemap",
281-
"--removeComments",
282-
"--mapRoot",
283-
"${maprootDirectory}",
284-
"--sourceRoot",
285-
"${sourcerootDirectory}",
286-
);
287-
}
288-
}
289266

290267
this.addRange(scenario?.args);
291268
this.addRange(options.compilerOptions);

ts-perf/packages/api/src/model/scenario.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ export interface ScenarioComponents {
1717
default?: boolean;
1818
disabled?: boolean;
1919
platforms?: string[];
20-
singleFileOutput?: boolean;
2120
configFile: string;
2221
tsserverConfig?: TSServerConfig;
2322
}
@@ -29,7 +28,6 @@ export class Scenario {
2928
public readonly default?: boolean;
3029
public readonly disabled?: boolean;
3130
public readonly platforms?: string[];
32-
public readonly singleFileOutput?: boolean;
3331
public readonly configFile: string;
3432
public readonly tsserverConfig?: TSServerConfig;
3533

@@ -45,7 +43,6 @@ export class Scenario {
4543
default?: boolean;
4644
disabled?: boolean;
4745
platforms?: string[];
48-
singleFileOutput?: boolean;
4946
tsserverConfig?: TSServerConfig;
5047
},
5148
) {
@@ -58,7 +55,6 @@ export class Scenario {
5855
this.default = options && options.default;
5956
this.disabled = options && options.disabled;
6057
this.platforms = options && options.platforms;
61-
this.singleFileOutput = options && options.singleFileOutput;
6258
this.configFile = configFile;
6359
this.tsserverConfig = options && options.tsserverConfig;
6460
}
@@ -241,7 +237,6 @@ export class Scenario {
241237
const { default: default_ = this.default } = components;
242238
const { disabled = this.disabled } = components;
243239
const { platforms = this.platforms } = components;
244-
const { singleFileOutput = this.singleFileOutput } = components;
245240
const { configFile = this.configFile } = components;
246241
const { tsserverConfig = this.tsserverConfig } = components;
247242
if (
@@ -251,7 +246,6 @@ export class Scenario {
251246
&& this.default === default_
252247
&& this.disabled === disabled
253248
&& this.platforms === platforms
254-
&& this.singleFileOutput === singleFileOutput
255249
&& this.configFile === configFile
256250
) {
257251
return this;
@@ -261,7 +255,6 @@ export class Scenario {
261255
default: default_,
262256
disabled,
263257
platforms,
264-
singleFileOutput,
265258
tsserverConfig,
266259
});
267260
}
@@ -278,7 +271,6 @@ export class Scenario {
278271
default: this.default,
279272
disabled: this.disabled,
280273
platforms: this.platforms && this.platforms.slice(),
281-
singleFileOutput: this.singleFileOutput,
282274
tsserverConfig: this.tsserverConfig,
283275
};
284276
}

ts-perf/packages/api/src/options.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ import { CommandLineOption, CommandLineOptionSet, CommandLineOptionSets, Command
66
export interface CompilerOptions {
77
tsc: string;
88
suite: string;
9-
full?: boolean;
109
compilerOptions?: string[];
1110
}
1211

@@ -63,10 +62,6 @@ const compiler: CommandLineOptionSet = {
6362
description: "Use <file> as the compiler (i.e. './built/local/tsc.js').",
6463
},
6564
suite,
66-
full: {
67-
type: "boolean",
68-
description: "Runs the compiler with additional options.",
69-
},
7065
compilerOptions: {
7166
type: "string",
7267
passthru: true,

0 commit comments

Comments
 (0)