Skip to content

Commit 2f9f6f9

Browse files
committed
remove debug variables and fix tsserver
1 parent dec7dc3 commit 2f9f6f9

2 files changed

Lines changed: 3 additions & 10 deletions

File tree

build/benchmark.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -269,15 +269,6 @@ jobs:
269269
node $(BENCH_SCRIPTS)/runTsPerf.js install-hosts
270270
displayName: Install hosts
271271
retryCountOnTaskFailure: 3
272-
- bash: |
273-
echo "REF=$(REF)"
274-
echo "IS_PR=$(IS_PR)"
275-
echo "TSPERF_IS_COMPARISON=$(TSPERF_IS_COMPARISON)"
276-
echo "TSPERF_NEW_COMMIT=$(TSPERF_NEW_COMMIT)"
277-
echo "TSPERF_BASELINE_COMMIT=$(TSPERF_BASELINE_COMMIT)"
278-
echo "REPO=$(REPO)"
279-
echo "TSGOFLAG=$(TSGOFLAG)"
280-
displayName: Debug variables
281272
- bash: |
282273
set -exo pipefail
283274
# Special case for self benchmark

ts-perf/packages/commands/src/benchmark/measure.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,9 @@ async function runTSServerScenario(
295295
const tsserver = resolveBuiltPath(options.builtDir, "tsserver");
296296
const temp = await getTempDirectories();
297297
const expansion = ExpansionProvider.getProviders({ runner: { kind: "tsserver", options }, temp, scenario, host });
298-
const argsBuilder = new CommandLineArgumentsBuilder(expansion, host, /*exposeGc*/ false)
298+
// use node as the tsserver host when using native binary
299+
const tsserverHost = host.executableFile ? host : Host.current;
300+
const argsBuilder = new CommandLineArgumentsBuilder(expansion, tsserverHost, /*exposeGc*/ false)
299301
.add(path.join(__dirname, "measuretsserver.js"))
300302
.add("--tsserver", tsserver)
301303
.add("--commands", scenario.configFile)

0 commit comments

Comments
 (0)