Simplify DynamicDataOperations: use FlattenHierarchy instead of manual hierarchy walk

Replace the manual type hierarchy walk with DeclaredOnly + loop with a single reflection call using BindingFlags.FlattenHierarchy. This lets the .NET runtime handle inheritance search for static members with its own built-in caching, removing the need for custom ConcurrentDictionary caches and the TypeMemberKey struct.

Author: Evangelink

src/TestFramework/TestFramework/Attributes/DataSource/DynamicDataOperations.cs

@@ -5,7 +5,7 @@ namespace Microsoft.VisualStudio.TestTools.UnitTesting;
 
 internal static class DynamicDataOperations
 {
-    private const BindingFlags DeclaredOnlyLookup = BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance | BindingFlags.Static | BindingFlags.DeclaredOnly;
+    private const BindingFlags MemberLookup = BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance | BindingFlags.Static | BindingFlags.FlattenHierarchy;
 
     public static IEnumerable<object[]> GetData(Type? dynamicDataDeclaringType, DynamicDataSourceType dynamicDataSourceType, string dynamicDataSourceName, object?[] dynamicDataSourceArguments, MethodInfo methodInfo)
     {
@@ -167,56 +167,11 @@ private static bool TryGetData(object dataSource, [NotNullWhen(true)] out IEnume
     }
 
     private static FieldInfo? GetFieldConsideringInheritance(Type type, string fieldName)
-    {
-        // NOTE: Don't use GetRuntimeField. It considers inheritance only for instance fields.
-        Type? currentType = type;
-        while (currentType is not null)
-        {
-            FieldInfo? field = currentType.GetField(fieldName, DeclaredOnlyLookup);
-            if (field is not null)
-            {
-                return field;
-            }
-
-            currentType = currentType.BaseType;
-        }
-
-        return null;
-    }
+        => type.GetField(fieldName, MemberLookup);
 
     private static PropertyInfo? GetPropertyConsideringInheritance(Type type, string propertyName)
-    {
-        // NOTE: Don't use GetRuntimeProperty. It considers inheritance only for instance properties.
-        Type? currentType = type;
-        while (currentType is not null)
-        {
-            PropertyInfo? property = currentType.GetProperty(propertyName, DeclaredOnlyLookup);
-            if (property is not null)
-            {
-                return property;
-            }
-
-            currentType = currentType.BaseType;
-        }
-
-        return null;
-    }
+        => type.GetProperty(propertyName, MemberLookup);
 
     private static MethodInfo? GetMethodConsideringInheritance(Type type, string methodName)
-    {
-        // NOTE: Don't use GetRuntimeMethod. It considers inheritance only for instance methods.
-        Type? currentType = type;
-        while (currentType is not null)
-        {
-            MethodInfo? method = currentType.GetMethod(methodName, DeclaredOnlyLookup);
-            if (method is not null)
-            {
-                return method;
-            }
-
-            currentType = currentType.BaseType;
-        }
-
-        return null;
-    }
+        => type.GetMethod(methodName, MemberLookup);
 }