Avoid long path issues for pipes by @Youssef1313 in #6536 (backport to rel/3.10) (#6538)

Co-authored-by: Youssef1313 <youssefvictor00@gmail.com>

Author: youssef-backport-bot

src/Platform/Microsoft.Testing.Platform/IPC/NamedPipeServer.cs

@@ -22,6 +22,8 @@ internal sealed class NamedPipeServer : NamedPipeBase, IServer
         ;
 #pragma warning restore CA1416 // Validate platform compatibility
 
+    private static bool IsUnix => Path.DirectorySeparatorChar == '/';
+
     private readonly Func<IRequest, Task<IResponse>> _callback;
     private readonly IEnvironment _environment;
     private readonly NamedPipeServerStream _namedPipeServerStream;
@@ -277,32 +279,24 @@ private async Task InternalLoopAsync(CancellationToken cancellationToken)
     // If core MTP is updated, but old version of TRX is still used, it will try to call this overload at runtime.
     // Without it, MissingMethodException will be thrown at runtime.
     public static PipeNameDescription GetPipeName(string name)
-        => GetPipeName(name, new SystemEnvironment());
-
-    public static PipeNameDescription GetPipeName(string name, IEnvironment environment)
     {
-        if (RuntimeInformation.IsOSPlatform(OSPlatform.Windows))
+        if (!IsUnix)
         {
-            return new PipeNameDescription($"testingplatform.pipe.{name.Replace('\\', '.')}", false);
+            return new PipeNameDescription($"testingplatform.pipe.{name.Replace('\\', '.')}");
         }
 
-#pragma warning disable RS0030 // Do not use banned APIs - We are using IEnvironment, but we still need the enum from the Environment class in BCL. This is safe.
-        string directoryId = Path.Combine(environment.GetFolderPath(Environment.SpecialFolder.LocalApplicationData, Environment.SpecialFolderOption.None), name);
-#pragma warning disable RS0030 // Do not use banned APIs
-        Directory.CreateDirectory(directoryId);
-        return new PipeNameDescription(
-            !Directory.Exists(directoryId)
-                ? throw new DirectoryNotFoundException(string.Format(
-                    CultureInfo.InvariantCulture,
-#if PLATFORM_MSBUILD
-                    $"Directory: {directoryId} doesn't exist.",
-#else
-                    PlatformResources.CouldNotFindDirectoryErrorMessage,
-#endif
-                    directoryId))
-                : Path.Combine(directoryId, ".p"), true);
+        // Similar to https://github.com/dotnet/roslyn/blob/99bf83c7bc52fa1ff27cf792db38755d5767c004/src/Compilers/Shared/NamedPipeUtil.cs#L26-L42
+        return new PipeNameDescription(Path.Combine("/tmp", name));
     }
 
+    // For compatibility only.
+    // Old versions of MTP used to have this overload without IEnvironment.
+    // Extensions (e.g, TRX) calls into this overload.
+    // If core MTP is updated, but old version of TRX is still used, it will try to call this overload at runtime.
+    // Without it, MissingMethodException will be thrown at runtime.
+    public static PipeNameDescription GetPipeName(string name, IEnvironment _)
+        => GetPipeName(name);
+
     public void Dispose()
     {
         if (_disposed)

src/Platform/Microsoft.Testing.Platform/IPC/PipeNameDescription.cs

@@ -3,32 +3,13 @@
 
 namespace Microsoft.Testing.Platform.IPC;
 
-internal sealed class PipeNameDescription(string name, bool isDirectory) : IDisposable
+internal sealed class PipeNameDescription(string name) : IDisposable
 {
-    private readonly bool _isDirectory = isDirectory;
-    private bool _disposed;
-
     public string Name { get; } = name;
 
+    // This is available via IVT.
+    // Avoid removing it as it can be seen as a binary breaking change when users use newer version of core MTP but older version of one of the extensions.
     public void Dispose()
     {
-        if (_disposed)
-        {
-            return;
-        }
-
-        if (_isDirectory)
-        {
-            try
-            {
-                Directory.Delete(Path.GetDirectoryName(Name)!, true);
-            }
-            catch (IOException)
-            {
-                // This folder is created inside the temp directory and will be cleaned up eventually by the OS
-            }
-        }
-
-        _disposed = true;
     }
 }