Backward-compatible approach, with functions still added to targetFiles

Author: abdurriq

src/artifacts-helper/devcontainer-feature.json

@@ -51,18 +51,27 @@
         },
         "shimDirectory": {
             "type": "string",
-            "default": "/usr/local/bin",
+            "default": "/usr/local/share/codespace-shims",
             "description": "Directory where the shims will be installed. This must be in $PATH, and needs to be as early as possible in priority for the scripts to override the base executables."
         },
+        "targetFiles": {
+            "type": "string",
+            "default": "DEFAULT",
+            "description": "Comma separated list of files to write to. Default is '/etc/bash.bashrc,/etc/zsh/zshrc' for root and '~/.bashrc,~/.zshrc' for non-root"
+        },
         "python": {
             "type": "boolean",
             "default": false,
             "description": "Install Python keyring helper for pip"
         }
     },
+    "containerEnv": {
+        "PATH": "${shimDirectory}:${PATH}"
+    },
     "installsAfter": [
         "ghcr.io/devcontainers/features/common-utils",
-        "ghcr.io/devcontainers/features/python"
+        "ghcr.io/devcontainers/features/python",
+        "ghcr.io/devcontainers/features/node"
     ],
     "customizations": {
         "vscode": {

src/artifacts-helper/install.sh

@@ -12,7 +12,7 @@ ALIAS_NPX="${NPXALIAS:-"true"}"
 ALIAS_RUSH="${RUSHALIAS:-"true"}"
 ALIAS_PNPM="${PNPMALIAS:-"true"}"
 INSTALL_PIP_HELPER="${PYTHON:-"false"}"
-SHIM_DIRECTORY="${SHIMDIRECTORY:-"/usr/local/bin"}"
+SHIM_DIRECTORY="${SHIMDIRECTORY:-"/usr/local/share/codespace-shims"}"
 
 ALIASES_ARR=()
 
@@ -108,6 +108,29 @@ if command -v sudo >/dev/null 2>&1; then
     fi
 fi
 
+if [ "${COMMA_SEP_TARGET_FILES}" = "DEFAULT" ]; then
+    if [ "${INSTALL_WITH_SUDO}" = "true" ]; then
+        COMMA_SEP_TARGET_FILES="~/.bashrc,~/.zshrc"
+    else
+        COMMA_SEP_TARGET_FILES="/etc/bash.bashrc,/etc/zsh/zshrc"
+    fi
+fi
+
+IFS=',' read -r -a TARGET_FILES_ARR <<< "$COMMA_SEP_TARGET_FILES"
+
+ALIASES_BLOCK=""
+for ALIAS in "${ALIASES_ARR[@]}"; do
+    ALIASES_BLOCK+="$ALIAS() { \"${SHIM_DIRECTORY}/$ALIAS\" \"\$@\"; }\n"
+done
+
+for TARGET_FILE in "${TARGET_FILES_ARR[@]}"; do
+    if [ "${INSTALL_WITH_SUDO}" = "true" ]; then
+        sudo -u ${_REMOTE_USER} bash -c "printf '%s' \"$ALIASES_BLOCK\" >> $TARGET_FILE"
+    else
+        printf '%s' "$ALIASES_BLOCK" >> "$TARGET_FILE" || true
+    fi
+done
+
 if [ "${INSTALL_WITH_SUDO}" = "true" ]; then
     sudo -u ${_REMOTE_USER} bash -c "/tmp/install-provider.sh ${USENET6}"
 fi