Add test to verify that scripts are still executed even if ado-helper fails

Author: abdurriq

src/artifacts-helper/README.md

@@ -77,14 +77,14 @@ to download the package.
 
 The shim scripts (e.g., `dotnet`, `npm`, `nuget`) now include a wait mechanism for the Azure DevOps authentication helper. When invoked, these scripts will:
 
-1. Wait up to 3 minutes for the `ado-auth-helper` to become available
+1. Wait up to 3 minutes for the `ado-auth-helper` to become available (configurable via `MAX_WAIT` environment variable)
 2. Display progress indicators every 20 seconds while waiting
 3. Continue execution once authentication is successful
-4. Return an error (but not terminate dependent scripts) if the helper is not available after the timeout
+4. **Continue with the underlying command even if authentication is not available** after the timeout
 
-This ensures that package restore operations can proceed even if there's a slight delay in the authentication helper installation, which can occur in some codespace initialization scenarios.
+This ensures that package restore operations can proceed even if there's a slight delay in the authentication helper installation, which can occur in some codespace initialization scenarios. Commands will still execute without authentication, though they may fail to access private Azure Artifacts feeds.
 
-The scripts are designed to be sourced safely, meaning they won't terminate the calling shell if authentication fails - they will simply return an error code that can be handled by the calling script.
+The scripts are designed to be sourced safely, meaning they won't terminate the calling shell if authentication fails - they will simply return an error code and allow the underlying tool to execute. This allows you to work with public packages or other package sources even when Azure Artifacts authentication is unavailable.
 
 ## OS Support
 
@@ -102,11 +102,6 @@ devcontainer features test -f artifacts-helper
 devcontainer features test -f artifacts-helper --scenario test_auth_wait
 ```
 
-The test suite includes:
-- **test_auth_wait.sh**: Verifies that auth-ado.sh can be sourced without terminating the shell
-- **test_shim_integration.sh**: Tests that shim scripts properly handle missing authentication helper
-- **Python keyring tests**: Validates Python package installation with Azure Artifacts authentication
-
 ## Changing where functions are configured
 
 By default, the functions are defined in `/etc/bash.bashrc` and `/etc/zsh/zshrc` if the container user is `root`, otherwise `~/.bashrc` and `~/.zshrc`.

src/artifacts-helper/scripts/auth-ado.sh

@@ -3,7 +3,8 @@
 echo "::step::Waiting for AzDO Authentication Helper..."
 
 # Wait up to 3 minutes for the ado-auth-helper to be installed
-MAX_WAIT=180
+# Can be overridden via environment variable for testing
+MAX_WAIT=${MAX_WAIT:-180}
 ELAPSED=0
 
 while [ $ELAPSED -lt $MAX_WAIT ]; do
@@ -22,8 +23,8 @@ while [ $ELAPSED -lt $MAX_WAIT ]; do
     fi
 done
 
-# Timeout reached
-echo "::error::AzDO Authentication Helper not found after ${MAX_WAIT} seconds"
+# Timeout reached - continue without authentication
+echo "::warning::AzDO Authentication Helper not found after ${MAX_WAIT} seconds"
 echo "Expected location: ${HOME}/ado-auth-helper"
-echo "Restore cannot proceed without authentication"
+echo "Continuing without Azure Artifacts authentication..."
 return 1

test/artifacts-helper/scenarios.json

@@ -58,5 +58,17 @@
                 "nugetAlias": true
             }
         }
+    },
+    "test_fallback_execution": {
+        "image": "mcr.microsoft.com/devcontainers/base:debian",
+        "features": {
+            "ghcr.io/devcontainers/features/dotnet:1": {},
+            "ghcr.io/devcontainers/features/node:1": {},
+            "artifacts-helper": {
+                "dotnetAlias": true,
+                "npmAlias": true,
+                "nugetAlias": true
+            }
+        }
     }
 }

test/artifacts-helper/test_auth_wait.sh

@@ -9,6 +9,7 @@ check "npm shim exists" test -f /usr/local/share/codespace-shims/npm
 check "nuget shim exists" test -f /usr/local/share/codespace-shims/nuget
 
 # Test that auth-ado.sh can be sourced without exiting the shell
+export MAX_WAIT=5
 check "auth-ado.sh can be sourced" bash -c 'source /usr/local/share/codespace-shims/auth-ado.sh 2>/dev/null || true; echo "still running"'
 
 # Test that sourcing auth-ado.sh doesn't terminate the parent shell

test/artifacts-helper/test_fallback_execution.sh

@@ -0,0 +1,46 @@
+#!/usr/bin/env bash
+
+# Import test library bundled with the devcontainer CLI
+source dev-container-features-test-lib || exit 1
+
+# Test that shim scripts call the underlying command even when auth helper is not found
+
+# Create a temporary directory to simulate a clean environment
+TEST_HOME=$(mktemp -d)
+
+# Mock scenario: ado-auth-helper doesn't exist, but the underlying command should still run
+check "dotnet command executes without auth helper" bash -c '
+    # Use a short timeout to avoid waiting 3 minutes
+    # The shim should call dotnet even if auth fails
+    export HOME='"$TEST_HOME"'
+    export MAX_WAIT=5
+    
+    # Call dotnet --version which should work even without auth
+    timeout 10 /usr/local/share/codespace-shims/dotnet --version 2>&1 | grep -q "dotnet\|\.NET" && echo "SUCCESS" || echo "FAILED"
+' | grep -q "SUCCESS"
+
+# Test with npm as well
+check "npm command executes without auth helper" bash -c '
+    export HOME='"$TEST_HOME"'
+    export MAX_WAIT=5
+    
+    # npm --version should work without auth
+    timeout 10 /usr/local/share/codespace-shims/npm --version 2>&1 | grep -q "[0-9]\+\.[0-9]\+\.[0-9]\+" && echo "SUCCESS" || echo "FAILED"
+' | grep -q "SUCCESS"
+
+# Test that nuget can be called (may not return version without auth, but should not crash)
+check "nuget command attempts to execute without auth helper" bash -c '
+    export HOME='"$TEST_HOME"'
+    export MAX_WAIT=5
+    
+    # Try to call nuget - it should attempt to run even if auth fails
+    timeout 10 /usr/local/share/codespace-shims/nuget help 2>&1 || true
+    # Just verify we get here without the shell crashing
+    echo "completed"
+' | grep -q "completed"
+
+# Cleanup
+rm -rf "$TEST_HOME"
+
+# Report results
+reportResults