[fix] script_runner: anchor runtime detection patterns to prevent false positives (#563)

* fix: use anchored patterns in script_runner runtime detection

Bare substring matching in _detect_runtime and _transform_runtime_command
caused false positives when a runtime name appeared inside a flag value.
For example, `copilot --model gpt-5.3-codex -p file.prompt.md` was
mis-detected as a codex command and transformed into `codex exec ...`,
producing "No such file or directory: 'codex'" at runtime.

- is_runtime_cmd: switch from `runtime in command` to word-boundary regex
- _detect_runtime: use `(?:^|\s)runtime(?:\s|$)` instead of bare `in`
- _transform_runtime_command: anchor codex/copilot/llm regexes with `^`

Fixes #396, closes #454.

* fix: replace em dash with ASCII hyphen in test comment

Repo requires source files to stay within printable ASCII to avoid
Windows cp1252 UnicodeEncodeError.

---------

Co-authored-by: Daniel Meppiel <51440732+danielmeppiel@users.noreply.github.com>

Author: edenfunf

src/apm_cli/core/script_runner.py

@@ -261,7 +261,8 @@ def _auto_compile_prompts(
 
             # Check if this is a runtime command (copilot, codex, llm) before transformation
             is_runtime_cmd = any(
-                runtime in command for runtime in ["copilot", "codex", "llm"]
+                re.search(r"(?:^|\s)" + runtime + r"(?:\s|$)", command)
+                for runtime in ["copilot", "codex", "llm"]
             ) and re.search(re.escape(prompt_file), command)
 
             # Transform command based on runtime pattern
@@ -343,7 +344,7 @@ def _transform_runtime_command(
         # Handle individual runtime patterns without environment variables
 
         # Handle "codex [args] file.prompt.md [more_args]" -> "codex exec [args] [more_args]"
-        if re.search(r"codex\s+.*" + re.escape(prompt_file), command):
+        if re.search(r"^codex\s+.*" + re.escape(prompt_file), command):
             match = re.search(
                 r"codex\s+(.*?)(" + re.escape(prompt_file) + r")(.*?)$", command
             )
@@ -359,7 +360,7 @@ def _transform_runtime_command(
                 return result
 
         # Handle "copilot [args] file.prompt.md [more_args]" -> "copilot [args] [more_args]"
-        elif re.search(r"copilot\s+.*" + re.escape(prompt_file), command):
+        elif re.search(r"^copilot\s+.*" + re.escape(prompt_file), command):
             match = re.search(
                 r"copilot\s+(.*?)(" + re.escape(prompt_file) + r")(.*?)$", command
             )
@@ -378,7 +379,7 @@ def _transform_runtime_command(
                 return result
 
         # Handle "llm [args] file.prompt.md [more_args]" -> "llm [args] [more_args]"
-        elif re.search(r"llm\s+.*" + re.escape(prompt_file), command):
+        elif re.search(r"^llm\s+.*" + re.escape(prompt_file), command):
             match = re.search(
                 r"llm\s+(.*?)(" + re.escape(prompt_file) + r")(.*?)$", command
             )
@@ -410,12 +411,11 @@ def _detect_runtime(self, command: str) -> str:
             Name of the detected runtime (copilot, codex, llm, or unknown)
         """
         command_lower = command.lower().strip()
-        # Check for runtime keywords anywhere in the command, not just at the start
-        if "copilot" in command_lower:
+        if re.search(r"(?:^|\s)copilot(?:\s|$)", command_lower):
             return "copilot"
-        elif "codex" in command_lower:
+        elif re.search(r"(?:^|\s)codex(?:\s|$)", command_lower):
             return "codex"
-        elif "llm" in command_lower:
+        elif re.search(r"(?:^|\s)llm(?:\s|$)", command_lower):
             return "llm"
         else:
             return "unknown"

tests/unit/test_script_runner.py

@@ -118,18 +118,46 @@ def test_transform_runtime_command_copilot_removes_p_flag(self):
     def test_detect_runtime_copilot(self):
         """Test runtime detection for copilot commands."""
         assert self.script_runner._detect_runtime("copilot --log-level all") == "copilot"
-    
+
     def test_detect_runtime_codex(self):
         """Test runtime detection for codex commands."""
         assert self.script_runner._detect_runtime("codex exec --skip-git-repo-check") == "codex"
-    
+
     def test_detect_runtime_llm(self):
         """Test runtime detection for llm commands."""
         assert self.script_runner._detect_runtime("llm --model gpt-4") == "llm"
-    
+
     def test_detect_runtime_unknown(self):
         """Test runtime detection for unknown commands."""
         assert self.script_runner._detect_runtime("unknown-command") == "unknown"
+
+    def test_detect_runtime_model_name_containing_codex(self):
+        """codex as a substring of a model name should not be detected as the codex runtime."""
+        # e.g. copilot --model gpt-5.3-codex - the runtime is copilot, not codex
+        assert self.script_runner._detect_runtime("copilot --model gpt-5.3-codex") == "copilot"
+
+    def test_detect_runtime_hyphenated_codex(self):
+        """A hyphen-prefixed codex substring must not trigger codex detection."""
+        assert self.script_runner._detect_runtime("run-codex-tool --flag") == "unknown"
+
+    def test_transform_runtime_command_copilot_with_codex_model(self):
+        """copilot command using --model containing 'codex' must not be mis-routed to codex runtime."""
+        original = "copilot --allow-all-tools --model gpt-5.3-codex -p fix-issue.prompt.md"
+        result = self.script_runner._transform_runtime_command(
+            original, "fix-issue.prompt.md", self.compiled_content, self.compiled_path
+        )
+        # Should be treated as a copilot command, not transformed into "codex exec ..."
+        assert result.startswith("copilot")
+        assert "codex exec" not in result
+
+    def test_transform_runtime_command_copilot_with_codex_model_name(self):
+        """--model codex (bare word as model name) must not trigger codex runtime path."""
+        original = "copilot --model codex -p fix-issue.prompt.md"
+        result = self.script_runner._transform_runtime_command(
+            original, "fix-issue.prompt.md", self.compiled_content, self.compiled_path
+        )
+        assert result.startswith("copilot")
+        assert "codex exec" not in result
 
     @patch('subprocess.run')
     @patch('apm_cli.core.script_runner.shutil.which', return_value=None)