Skip to content

Commit 80aec9b

Browse files
authored
Downgrade dependencies so the source analyzer works with .NET 8 SDK again (#1555)
* Downgrade code analyzers so the source analyzer works in .NET 8 again * Update comments and docs
1 parent ed8d12c commit 80aec9b

4 files changed

Lines changed: 8 additions & 12 deletions

File tree

Directory.Packages.Analyzers.props

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
<Project>
22
<PropertyGroup>
3-
<CodeAnalysisVersionForAnalyzers>4.14.0</CodeAnalysisVersionForAnalyzers>
3+
<CodeAnalysisVersionForAnalyzers>4.11.0</CodeAnalysisVersionForAnalyzers>
44
</PropertyGroup>
55
<ItemGroup>
6-
<!-- These versions carefully chosen to support VS 2022 Update 14. -->
6+
<!-- These versions carefully chosen to support VS 2022 Update 14 and also run down to .NET 8. -->
77
<PackageVersion Update="Microsoft.CodeAnalysis.Common" Version="$(CodeAnalysisVersionForAnalyzers)" />
88
<PackageVersion Update="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="$(CodeAnalysisVersionForAnalyzers)" />
99
<PackageVersion Update="Microsoft.CodeAnalysis.CSharp" Version="$(CodeAnalysisVersionForAnalyzers)" />
10-
<PackageVersion Update="System.Collections.Immutable" Version="9.0.0" />
10+
<PackageVersion Update="System.Collections.Immutable" Version="8.0.0" />
1111
<PackageVersion Update="System.Memory" Version="4.5.5" />
12-
<PackageVersion Update="System.Reflection.Metadata" Version="9.0.0" />
13-
<PackageVersion Include="System.Text.Encodings.Web" Version="9.0.0" />
14-
<PackageVersion Update="System.Text.Json" Version="9.0.0" />
12+
<PackageVersion Update="System.Reflection.Metadata" Version="8.0.0" />
13+
<PackageVersion Include="System.Text.Encodings.Web" Version="8.0.0" />
14+
<PackageVersion Update="System.Text.Json" Version="8.0.0" />
1515
</ItemGroup>
1616
</Project>

Directory.Packages.props

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141
<PackageVersion Include="Xunit.Combinatorial" Version="2.0.24" />
4242
<PackageVersion Include="Xunit.Assert" Version="2.9.3" />
4343
</ItemGroup>
44-
<Import Project="Directory.Packages.Analyzers.props" Condition="'$(IsTestProject)'!='true'" />
44+
<Import Project="Directory.Packages.Analyzers.props" Condition="'$(IsTestProject)'!='true' and '$(MSBuildProjectName)'!='CsWin32Generator'" />
4545
<ItemGroup Label="Library.Template">
4646
<PackageVersion Include="Microsoft.NET.Test.Sdk" Version="18.0.0" />
4747
<PackageVersion Include="Microsoft.VisualStudio.Internal.MicroBuild.NonShipping" Version="$(MicroBuildVersion)" />

docfx/docs/getting-started.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
## Prerequisites
44

5-
The .NET 8 SDK or Visual Studio 2019 Update 11 (16.11).
5+
The .NET 8 SDK or Visual Studio 2022 Update 14 (16.14).
66

77
WPF projects have [additional requirements](https://github.com/microsoft/CsWin32/issues/7).
88

src/Microsoft.Windows.CsWin32/FastSyntaxFactory.cs

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,10 +76,6 @@ internal static SyntaxToken Token(SyntaxKind kind)
7676

7777
internal static ImplicitArrayCreationExpressionSyntax ImplicitArrayCreationExpression(InitializerExpressionSyntax initializerExpression) => SyntaxFactory.ImplicitArrayCreationExpression(Token(SyntaxKind.NewKeyword), Token(SyntaxKind.OpenBracketToken), default, Token(SyntaxKind.CloseBracketToken), initializerExpression);
7878

79-
internal static CollectionExpressionSyntax CollectionExpression(SeparatedSyntaxList<CollectionElementSyntax> elements = default) => SyntaxFactory.CollectionExpression(elements);
80-
81-
internal static ExpressionElementSyntax ExpressionElement(ExpressionSyntax expression) => SyntaxFactory.ExpressionElement(expression);
82-
8379
internal static ForStatementSyntax ForStatement(VariableDeclarationSyntax? declaration, ExpressionSyntax condition, SeparatedSyntaxList<ExpressionSyntax> incrementors, StatementSyntax statement)
8480
{
8581
SyntaxToken semicolonToken = SyntaxFactory.Token(TriviaList(), SyntaxKind.SemicolonToken, TriviaList(Space));

0 commit comments

Comments
 (0)