You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Follow-up from PR #167 review. GroupV2 timing/policy is currently a bare re-export of de_mls::ConversationConfig (aliased GroupV2Config) threaded through several layers:
the for_testServiceContext scaffolding (core/conversations/src/service_context.rs, test-only)
the client builder's group_v2 option (crates/client/src/builder.rs)
This leaks the de_mls type from core through libchat to the client builder, crossing abstraction layers and risking interop churn as de_mls evolves. It is Option/None-defaulted behind the builder, so current developer impact is small.
What's needed
GroupV2 provides a sensible default configuration for network operation; the millisecond test profile stays in the test harnesses.
Follow-up from PR #167 review. GroupV2 timing/policy is currently a bare re-export of
de_mls::ConversationConfig(aliasedGroupV2Config) threaded through several layers:Core::set_group_v2_config/ServiceContext.group_v2_config(core/conversations/src/core.rs,service_context.rs)for_testServiceContextscaffolding (core/conversations/src/service_context.rs, test-only)group_v2option (crates/client/src/builder.rs)This leaks the de_mls type from core through libchat to the client builder, crossing abstraction layers and risking interop churn as de_mls evolves. It is
Option/None-defaulted behind the builder, so current developer impact is small.What's needed
Raised by @jazzz (review comments on
builder.rs,service_context.rs,core.rsset_group_v2_config, and the approval note).