Skip to content

Commit 9b24854

Browse files
authored
fix(datasets): url encode dataset name and run name (#980)
1 parent ad7705f commit 9b24854

1 file changed

Lines changed: 8 additions & 5 deletions

File tree

langfuse/client.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,9 @@ def get_dataset(
361361
page = 1
362362
while True:
363363
new_items = self.client.dataset_items.list(
364-
dataset_name=name, page=page, limit=fetch_items_page_size
364+
dataset_name=self._url_encode(name),
365+
page=page,
366+
limit=fetch_items_page_size,
365367
)
366368
dataset_items.extend(new_items.data)
367369
if new_items.meta.total_pages <= page:
@@ -429,7 +431,7 @@ def get_dataset_runs(
429431
try:
430432
self.log.debug("Getting dataset runs")
431433
return self.client.datasets.get_runs(
432-
dataset_name=dataset_name, page=page, limit=limit
434+
dataset_name=self._url_encode(dataset_name), page=page, limit=limit
433435
)
434436
except Exception as e:
435437
handle_fern_exception(e)
@@ -454,7 +456,8 @@ def get_dataset_run(
454456
f"Getting dataset runs for dataset {dataset_name} and run {dataset_run_name}"
455457
)
456458
return self.client.datasets.get_run(
457-
dataset_name=dataset_name, run_name=dataset_run_name
459+
dataset_name=self._url_encode(dataset_name),
460+
run_name=self._url_encode(dataset_run_name),
458461
)
459462
except Exception as e:
460463
handle_fern_exception(e)
@@ -478,7 +481,7 @@ def create_dataset(
478481
"""
479482
try:
480483
body = CreateDatasetRequest(
481-
name=name, description=description, metadata=metadata
484+
name=self._url_encode(name), description=description, metadata=metadata
482485
)
483486
self.log.debug(f"Creating datasets {body}")
484487
return self.client.datasets.create(request=body)
@@ -531,7 +534,7 @@ def create_dataset_item(
531534
"""
532535
try:
533536
body = CreateDatasetItemRequest(
534-
datasetName=dataset_name,
537+
datasetName=self._url_encode(dataset_name),
535538
input=input,
536539
expectedOutput=expected_output,
537540
metadata=metadata,

0 commit comments

Comments
 (0)