Skip to content
This repository was archived by the owner on Dec 15, 2020. It is now read-only.
This repository was archived by the owner on Dec 15, 2020. It is now read-only.

Use OBSDALCMSampleBufferCreateFromDataNoCopy to eliminate a framebuffer memory copy #259

Description

@johnboiles

We could potentially improve performance by using OBSDALCMSampleBufferCreateFromDataNoCopy instead of OBSDALCMSampleBufferCreateFromData which should remove a memory copy of the framebuffer, saving a bit of performance and latency transferring the frames from OBS to the virtual camera.

When I tried this, it seemed to work just fine when using the OBS Virtual Camera device in other programs. But when using the plugin as a source in OBS (looping back the output of OBS), it didn't work. Strangely when I'd set the source to a lower resolution than the output it would work for some reason. This made me worried that using OBSDALCMSampleBufferCreateFromDataNoCopy could cause problems in some programs. I'm really not sure why this is, but it's possible this is a bug in OBS, and in fact this plugin would be just fine eliminating this memory copy. More investigation is needed.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestperformanceReport of choppy or freezing video or general slowness

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions