Codegen fails with conditional operand for arithmetic function

[timmw]

Issue Description

When attempting to use a conditional as an operand for an arithmetic function jank produces an error:

user=> (* (if true 1) 2)
In file included from <<< inputs >>>:1:
/tmp/jank-repl-DWzD3q:3:57: error: no viable conversion from
      'jank::runtime::oref<object>' to 'int'
    3 | auto const v15(jank::runtime::convert<int>::into_object(v14));
      |                                                         ^~~
/home/tim/src/third-party/jank/compiler+runtime/include/cpp/jank/runtime/convert/builtin.hpp:227:43: note:
      passing argument to parameter 'o' here
  227 |     static object_ref into_object(T const o)
      |                                           ^
error: Parsing failed.
─ internal/codegen-failure ────────────────────────────────────────────────────
error: Unable to compile C++ source.

Reproduction Steps

Eval this in repl:

(* (if true 1) 2)

jank health check

─ system ──────────────────────────────────────────────────────────────────────
─ ✅ operating system: linux
─ ✅ default triple: x86_64-unknown-linux-gnu

─ jank install ────────────────────────────────────────────────────────────────
─ ✅ jank version: jank-0.1-alpha
─ ✅ jank resource dir: ../lib/jank/0.1
─ ✅ jank resolved resource dir: /home/tim/.local/bin/../lib/jank/0.1 (found)
─ ✅ jank user cache dir: /home/tim/.cache/jank/x86_64-unknown-linux-gnu-c89264ae995a47f2555460e0b3253b579bc1aa3c3ac6435e57f6d6a107541d20 (found)

─ clang install ───────────────────────────────────────────────────────────────
─ ✅ configured clang path: /nix/store/9g5ba0n1q617mcbqk8y1lcwzlsdvdknl-clang-wrapper-22.1.2/bin/clang++ (found)
─ ✅ configured clang resource dir: /nix/store/9g5ba0n1q617mcbqk8y1lcwzlsdvdknl-clang-wrapper-22.1.2/resource-root (found)

─ jank runtime ────────────────────────────────────────────────────────────────
─ ✅ jank runtime initialized
─ ✅ jank pch path: /home/tim/.cache/jank/x86_64-unknown-linux-gnu-c89264ae995a47f2555460e0b3253b579bc1aa3c3ac6435e57f6d6a107541d20 (found)
─ ✅ jank can jit compile c++
─ ✅ jank can aot compile working binaries

─ support ─────────────────────────────────────────────────────────────────────
If you're having issues with jank, please either ask the jank community on the Clojurians Slack or report the issue on Github.

─ Slack: https://clojurians.slack.com/archives/C03SRH97FDK
─ Github: https://github.com/jank-lang/jank

Stack trace

No response

OS Version Information

Fedora 43

I acknowledge that:

• I have searched the jank repository (both open and closed Discussions and Issues) and confirm this is not a duplicate of an existing issue or discussion.
• I have checked the "Preview" tab on all text fields to ensure that everything looks right, and have wrapped all configuration and code in code blocks with a group of three backticks (```) on separate lines.

[jeaye]

Excellent report and minimal repro. I'll get this fixed and tested.

[jeaye]

This has been fixed and tested: #833

[timmw]

Thank you for the rapid fix!

I discovered the issue is slightly wider than initially thought:

Else branch same type:

user=> (* (if true 1 1) 1)
In file included from <<< inputs >>>:1:
/tmp/jank-repl-JiaUyU:3:57: error: no viable conversion from 'jank::runtime::oref<object>' to 'int'
    3 | auto const v15(jank::runtime::convert<int>::into_object(v14));
      |                                                         ^~~
/home/tim/src/third-party/jank/compiler+runtime/include/cpp/jank/runtime/convert/builtin.hpp:227:43: note:
      passing argument to parameter 'o' here
  227 |     static object_ref into_object(T const o)
      |                                           ^
error: Parsing failed.
─ internal/codegen-failure ─────────────────────────────────────────────────────────────────────────
error: Unable to compile C++ source.

Else branch different type:

user=> (* (if true 1 1.0) 1)
1

Else branch same type, alternate branch different type:

user=> (* (if true 1.0 1) 1)
1.0

Both branches different types:

user=> (* (if true 1.0 1.0) 1)
In file included from <<< inputs >>>:1:
/tmp/jank-repl-R8qIVD:3:60: error: no viable conversion from 'jank::runtime::oref<object>' to 'double'
    3 | auto const v15(jank::runtime::convert<double>::into_object(v14));
      |                                                            ^~~
/home/tim/src/third-party/jank/compiler+runtime/include/cpp/jank/runtime/convert/builtin.hpp:277:52: note:
      passing argument to parameter 'o' here
  277 |     static obj::small_real_ref into_object(T const o)
      |                                                    ^
error: Parsing failed.
─ internal/codegen-failure ─────────────────────────────────────────────────────────────────────────
error: Unable to compile C++ source.

As above but types swapped, same issue but sublty different error message (no jank::runtime:: prefix)

user=> (* (if true 1 1) 1.0)
In file included from <<< inputs >>>:1:
/tmp/jank-repl-tzFrOH:3:60: error: no viable conversion from 'oref<object>' to 'double'
    3 | auto const v15(jank::runtime::convert<double>::into_object(v14));
      |                                                            ^~~
/home/tim/src/third-party/jank/compiler+runtime/include/cpp/jank/runtime/convert/builtin.hpp:277:52: note:
      passing argument to parameter 'o' here
  277 |     static obj::small_real_ref into_object(T const o)
      |                                                    ^
error: Parsing failed.
─ internal/codegen-failure ─────────────────────────────────────────────────────────────────────────
error: Unable to compile C++ source.

[jeaye]

Ah. You're right. I spotted this, as I was fixing it, which is why I added tests for then/else having different types, but there's one test I missed: them each having the same type. I can repro that locally, so I'll get it fixed and tested once I wrap up my current task.

[jeaye]

This is all fixed up now. :) Let me know if you have any more issues!