JSON-RPC: add optional directory hole punch to jamulusclient/connect

Mirror the new --connectdirectory option on the RPC side: connect now
accepts an optional "directory" param. When given, CClient::Connect
hole-punches through that directory (CLM_REQ_SERVER_LIST) before
connecting, so an RPC-driven client can reach a server behind a cloud
firewall/NAT the same way the GUI directory list does. A non-string
directory is rejected with invalid params; the server address is
connected to verbatim and need not be listed by the directory.

docs/JSON-RPC.md regenerated via tools/generate_json_rpc_docs.py.

Relates to jamulussoftware/jamuluswebsite#1122

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: jrd

docs/JSON-RPC.md

@@ -139,6 +139,7 @@ Parameters:
 | --- | --- | --- |
 | params.address | string | Socket address of the server (host:port). |
 | params.serverName | string | Optional human readable server name used for display purposes. Defaults to the address. |
+| params.directory | string | Optional socket address of a directory to hole-punch through before connecting (host:port). Use for a server behind a cloud firewall/NAT that is registered with that directory; address is connected to verbatim and need not be listed by the directory. Example: anygenre1.jamulus.io:22124 |
 
 Results:
 

src/clientrpc.cpp

@@ -264,6 +264,10 @@ CClientRpc::CClientRpc ( CClient* pClient, CClientSettings* pSettings, CRpcServe
     ///        notifications to follow its progress.
     /// @param {string} params.address - Socket address of the server (host:port).
     /// @param {string} params.serverName - Optional human readable server name used for display purposes. Defaults to the address.
+    /// @param {string} params.directory - Optional socket address of a directory to hole-punch through before
+    ///        connecting (host:port). Use for a server behind a cloud firewall/NAT that is registered with that
+    ///        directory; address is connected to verbatim and need not be listed by the directory. Example:
+    ///        anygenre1.jamulus.io:22124
     /// @result {string} result - "ok" once the connection attempt has been initiated.
     pRpcServer->HandleMethod ( "jamulusclient/connect", [=] ( const QJsonObject& params, QJsonObject& response ) {
         auto jsonAddress = params["address"];
@@ -273,11 +277,19 @@ CClientRpc::CClientRpc ( CClient* pClient, CClientSettings* pSettings, CRpcServe
             return;
         }
 
+        auto jsonDirectory = params["directory"];
+        if ( !jsonDirectory.isUndefined() && !jsonDirectory.isNull() && !jsonDirectory.isString() )
+        {
+            response["error"] = CRpcServer::CreateJsonRpcError ( CRpcServer::iErrInvalidParams, "Invalid params: directory is not a string" );
+            return;
+        }
+
         auto          jsonServerName = params["serverName"];
         const QString strAddress     = NetworkUtil::FixAddress ( jsonAddress.toString() );
         const QString strServerName  = jsonServerName.isString() ? jsonServerName.toString() : strAddress;
+        const QString strDirectory   = jsonDirectory.isString() ? NetworkUtil::FixAddress ( jsonDirectory.toString() ) : QString();
 
-        pClient->Connect ( strAddress, strServerName );
+        pClient->Connect ( strAddress, strServerName, strDirectory );
 
         response["result"] = "ok";
     } );