Skip to content

Implement the standard IDisposable pattern in unsealed classes #16

Description

@airbreather

A few classes implement System.IDisposable, but they do so without using the standard pattern. See CA1063:ImplementIDisposableCorrectly, including its "See Also" links, for a description of this pattern.

I'm wrapping up what I intend to submit for the native memory array implementation, and in my self-review, I noticed that I don't have a finalizer on the type, which got me thinking about this.

The types I see that directly implement System.IDisposable are:

  • Reminiscence.Arrays.ArrayBase<T>
  • Reminiscence.Collections.List<T>
  • Reminiscence.Indexes.Index<T>
  • Reminiscence.IO.MemoryMap
  • Reminiscence.IO.MappedAccessor<T>

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions