Skip to content

Changes CF error display headers#1309

Open
benjwadams wants to merge 1 commit into
ioos:mainfrom
benjwadams:cf_priority_names
Open

Changes CF error display headers#1309
benjwadams wants to merge 1 commit into
ioos:mainfrom
benjwadams:cf_priority_names

Conversation

@benjwadams
Copy link
Copy Markdown
Contributor

Changes CF error display headers to the following

  • 3: Required
  • 2: Recommended
  • 1: Suggested

Changes CF error display headers to the following
- 3: Required
- 2: Recommended
- 1: Suggested
@benjwadams
Copy link
Copy Markdown
Contributor Author

Implements #1304

@benjwadams
Copy link
Copy Markdown
Contributor Author

@ocefpaf, not directly related to this, but I had some trouble running the pre-commit tests for add-trailing-comma. It kept trying to run under the system Python (3.9) and erroring out even though I had an activated virtualenv running Python 3.11 series. It's possible I'm omitting something, so I don't want to make a separate issue quite yet.

@ocefpaf
Copy link
Copy Markdown
Member

ocefpaf commented May 13, 2026

@ocefpaf, not directly related to this, but I had some trouble running the pre-commit tests for add-trailing-comma. It kept trying to run under the system Python (3.9) and erroring out even though I had an activated virtualenv running Python 3.11 series. It's possible I'm omitting something, so I don't want to make a separate issue quite yet.

Python 3.9 reached EoL and compliance-checker is >=3.10 now. You can skip the checks with the option --no-verify when commiting.

@ocefpaf
Copy link
Copy Markdown
Member

ocefpaf commented May 13, 2026

Regarding this PR, after Monday's meeting I found @ksauby original issue and the PR that fixed it: #1262

If they are still experiexing the issue it is probably b/c the web-app at https://compliance.ioos.us/ was not updated yet.

Here we also change the nomenclature for CF, but that is not really specified in the CF documents and we had Errors, Warnings, and Info for so long that I'm not so sure we should change now.

TL;DR I don't think we should change it for CF here, unless they explicitly define a language for these in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants