release 1.2.1 - community extensions

Author: imprsnst

README.md

@@ -7,7 +7,7 @@
 <p align="center">
   <a href="LICENSE"><img alt="License: MIT" src="https://img.shields.io/badge/License-MIT-green?style=for-the-badge"></a>
   <a href="https://www.python.org/downloads/"><img alt="Python 3.11+" src="https://img.shields.io/badge/Python-3.11%2B-blue?style=for-the-badge&logo=python&logoColor=white"></a>
-  <a href="../../releases/latest"><img alt="Latest release" src="https://img.shields.io/badge/Release-v1.2.0-blue?style=for-the-badge"></a>
+  <a href="../../releases/latest"><img alt="Latest release" src="https://img.shields.io/badge/Release-v1.2.1-blue?style=for-the-badge"></a>
   <a href="https://discord.gg/cSUS88VdY9"><img alt="Join our Discord" src="https://img.shields.io/badge/Discord-Join%20the%20community-5865F2?logo=discord&logoColor=white&style=for-the-badge"></a>
 </p>
 

core/extensions/.cache/registry.json

@@ -1,7 +1,7 @@
 [project]
 # PyPI name; the import package is `inline_core` (src/inline_core).
 name = "inline-core"
-version = "1.2.0"
+version = "1.2.1"
 description = "The generation engine behind Inline Studio."
 readme = "README.md"
 requires-python = ">=3.11"

core/pyproject.toml

@@ -50,15 +50,15 @@ def status() -> dict[str, Any]:
         }
 
     def versions(extension_id: str) -> dict[str, Any]:
-        extension = ExtensionsRoot.resolve().extension(extension_id)
+        extension = installer.paths.extension(extension_id)
         return {
             "extensionId": extension_id,
             "current": extension.current() or "",
             "versions": extension.installed_versions(),
         }
 
     def registry_index(refresh: bool = False) -> dict[str, Any]:
-        return _registry_index(refresh=refresh)
+        return _registry_index(installer.paths, refresh=refresh)
 
     reg("list", installer.list_packs)
     reg("status", status)
@@ -72,13 +72,12 @@ def registry_index(refresh: bool = False) -> dict[str, Any]:
     reg("registryIndex", registry_index)
 
 
-def _registry_index(*, refresh: bool) -> dict[str, Any]:
+def _registry_index(paths: ExtensionsRoot, *, refresh: bool) -> dict[str, Any]:
     """The published extension list, from ``config.registry_url()``.
 
     Cached on disk with its ETag: a refresh is a conditional GET, and an unreachable registry
     degrades to the cached entries marked ``stale`` rather than an empty dialog.
     """
-    paths = ExtensionsRoot.resolve()
     cached, etag = _read_cache(paths)
     if not refresh and cached is not None:
         return {"entries": cached, "stale": False}

core/src/inline_core/extensions/handlers.py

@@ -146,6 +146,12 @@ def __init__(
     def state(self) -> StateStore:
         return self._state
 
+    @property
+    def paths(self) -> ExtensionsRoot:
+        """The root this installer works in. Callers must use this rather than resolving from the
+        environment, or they silently read and write a different directory."""
+        return self._paths
+
     # --- install ----------------------------------------------------------------------------------
 
     async def install(self, request: InstallRequest) -> InstallResult:

core/src/inline_core/extensions/install.py

@@ -486,3 +486,30 @@ def emit(self, event: Any) -> None:
 
     written = list(takes_dir.glob("*.png"))
     assert len(written) == 1, "the run wrote exactly one take"
+
+
+def test_every_channel_uses_the_installers_root_not_the_environment(
+    installer: Installer, tmp_path: Path
+) -> None:
+    """A regression guard: handlers once resolved the root from the environment, so `versions` and
+    `registryIndex` read and wrote a different directory than the installer used - which quietly
+    littered the repo's default `./extensions` during tests."""
+    import asyncio
+
+    from inline_core.extensions.handlers import register_extension_handlers
+
+    rpc = RpcRouter()
+    register_extension_handlers(rpc, installer)
+    _install(installer, _make_repo(tmp_path, _renamed(MANIFEST, "root-extension")))
+
+    async def call(channel: str, args: list[Any]) -> Any:
+        out = await rpc.dispatch(channel, args)
+        assert out["ok"], out
+        return out["value"]
+
+    versions = asyncio.run(call("ext:manage:versions", ["root-extension"]))
+    assert versions["versions"], "versions must be read from the installer's own root"
+
+    # The registry cache must land under the installer's root, never the process default.
+    asyncio.run(call("ext:manage:registryIndex", []))
+    assert not (Path.cwd() / "extensions").exists(), "wrote to the default root instead"

core/tests/test_extension_install.py

@@ -1,6 +1,6 @@
 {
   "name": "inline-studio",
-  "version": "1.2.0",
+  "version": "1.2.1",
   "description": "An experimentation layer for visual artists: a node canvas for building generative pipelines, served by the Inline Core engine.",
   "author": "Inline Studio",
   "license": "MIT",

package.json

@@ -1,6 +1,6 @@
 [project]
 name = "inline-studio-frontend"
-version = "1.2.0"
+version = "1.2.1"
 description = "Prebuilt Inline Studio web UI (SPA), served by Inline Core. Mirrors comfyui-frontend-package."
 requires-python = ">=3.9"
 readme = "README.md"