From a5fdab8b224b597d07cc90192f14cbaecc507b9a Mon Sep 17 00:00:00 2001
From: XZETGEXI <77068772+XZETGEXI@users.noreply.github.com>
Date: Mon, 18 Jan 2021 10:18:19 +0100
Subject: [PATCH] Use of NodeId for identifier

The method to identify nodes has two problems:
- A node with a single-word name (like "Example") will have the same name and caption, since there are no empty spaces to replace with "_". This will trigger an "Identifier is not unique" in GeNIe.
- Two nodes cannot have the same name, even if there are at different branches in the graph.

To solve these two problems, I suggest we use NodeId instead of node caption, for two reasons:
- The internal mechanic of NodeId, incrementing each time a node is created, ensures that every ID is unique.
- The name is displayed, not the ID, so the user interface is not changed too much.

Limitations:
Now the error will happen if you name a node something like "Node_1". But this is a more unlikely behaviour.
---
 pybn/network.py | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/pybn/network.py b/pybn/network.py
index e1318a6..1ac903d 100755
--- a/pybn/network.py
+++ b/pybn/network.py
@@ -466,7 +466,7 @@ def getSize(self):
   def printNode(self):
     # print node
     commentNode = '\t\t<!-- create node "'+self.caption+'" -->\n'
-    initNode = '\t\t<cpt id="'+self.name+'" >\n'
+    initNode = '\t\t<cpt id="'+self.nodeId+'" >\n'
     commentOutcomes = '\t\t\t<!-- setting names of outcomes -->\n'
     initOutcomes = ''
     for outcome in self.outcomes:
@@ -477,7 +477,7 @@ def printNode(self):
       commentArc = '\t\t\t<!-- add arcs -->\n'
       initArc = '\t\t\t<parents>'
       for connection in self.arcConnection:
-        initArc += connection[0]+' '
+        initArc += connection[1]+' '
       endArc =  '</parents>\n'
     else:
       commentArc = ''
@@ -495,7 +495,7 @@ def printNode(self):
     return print_node
 
   def printExtension(self):
-    initExtensions = '\t\t\t<node id="'+self.name+'">\n'
+    initExtensions = '\t\t\t<node id="'+self.nodeId+'">\n'
     initName = '\t\t\t\t<name>'+self.caption+'</name>\n'
     initIcolor = '\t\t\t\t<interior color="'+self.interior_color+'" />\n'
     initOcolor = '\t\t\t\t<outline color="'+self.outline_color+'" />\n'
@@ -508,7 +508,7 @@ def printExtension(self):
     return initExtensions+initName+initIcolor+initOcolor+initFont+initPos+initBar+endExtensions
 
   def printProbabilities(self):
-    commentProbabilities = '// setting probabilities for "'+self.name+'"\ntheProbs.Flush();\n'
+    commentProbabilities = '// setting probabilities for "'+self.nodeId+'"\ntheProbs.Flush();\n'
     initProbabilities = 'theProbs.SetSize('+str(len(self.probability))+');\n'
     for i,probability in enumerate(self.probability):
       initProbabilities += 'theProbs['+str(i)+'] = '+str(probability)+';\n'
@@ -622,7 +622,7 @@ class Arc(object):
   def __init__(self, from_node, to_node):
     self.from_node = from_node
     self.to_node = to_node
-    self.to_node.addArcConnection(self.from_node.getName(),self.from_node.getIdNum(),self.from_node.getSize())
+    self.to_node.addArcConnection(self.from_node.getName(),self.from_node.getNodeId(),self.from_node.getSize())
 
   def __repr__(self):
     return self.name