Close response stream on unsupported content encoding#10325
Open
jmestwa-coder wants to merge 1 commit into
Open
Close response stream on unsupported content encoding#10325jmestwa-coder wants to merge 1 commit into
jmestwa-coder wants to merge 1 commit into
Conversation
Member
|
Won't |
Collaborator
|
This makes the code more symmetrical (the stream is explicitly closed when encoding is correct, so closing it when it's incorrect makes sense). OTOH @tbroyer is right that the stream is closed automatically in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a response stream leak in
UrlRequestTransportwhen the server returns an unsupportedContent-Encoding.Problem
send()opens the responseInputStream.Content-Encodingis unsupported, the method reports a transport failure and returns immediately.Fix