Change: Rename DSL query naming mustNotExists to doesNotExist

Author: alex-heine

pkg/openSearch/osquery/boolQueryBuilder.go

@@ -151,7 +151,7 @@ func (q *BoolQueryBuilder) AddFilterRequest(request *filter.Request) error {
 		if handler, ok := operatorMapping[field.Operator]; ok {
 			value := field.Value
 
-			if field.Operator == filter.CompareOperatorExists || field.Operator == filter.CompareOperatorMustNotExists {
+			if field.Operator == filter.CompareOperatorExists || field.Operator == filter.CompareOperatorDoesNotExist {
 				value = "" // exists operator does not need a value, but for more consistent handling just pass a dummy value
 			}
 			if value == nil {
@@ -290,7 +290,7 @@ func defaultCompareOperators() []CompareOperator {
 			Handler:  HandleCompareOperatorExists, MustCondition: true,
 		},
 		{
-			Operator: filter.CompareOperatorMustNotExists,
+			Operator: filter.CompareOperatorDoesNotExist,
 			Handler:  HandleCompareOperatorExists, MustCondition: false,
 		},
 	}

pkg/openSearch/osquery/boolQueryBuilder_test.go

@@ -612,7 +612,7 @@ func TestBoolQueryBuilder_AddFilterRequest(t *testing.T) {
 	addTest("operator must not Exists", testCase{
 		filterRequest: singleFilter(filter.RequestField{
 			Name:     "keywordOmitEmptyField",
-			Operator: filter.CompareOperatorMustNotExists,
+			Operator: filter.CompareOperatorDoesNotExist,
 		}),
 		wantDocuments: []ostesting.TestType{doc0},
 	})

pkg/query/filter/type.go

@@ -75,7 +75,7 @@ CompareOperator ENUM(
 	betweenDates
 
 	exists
-	mustNotExists
+	doesNotExist
 
 	isEqualToRating
 	isNotEqualToRating