code review changes

Author: mgoetzegb

pkg/auth/auth_client.go

@@ -130,7 +130,7 @@ func (c *KeycloakClient) requestToken(ctx context.Context) (*authResponse, error
 	if resp.StatusCode != http.StatusOK {
 		respBody, err := io.ReadAll(resp.Body)
 		if err != nil {
-			respBody = []byte("failed to read response body: " + err.Error())
+			return nil, fmt.Errorf("authentication request failed with status: %s: %w body: %s", resp.Status, err, string(respBody))
 		}
 		return nil, fmt.Errorf("authentication request failed with status: %s: %s", resp.Status, string(respBody))
 	}

pkg/auth/auth_client_test.go

@@ -52,7 +52,7 @@ func TestKeycloakClient_GetToken(t *testing.T) {
 				// the other fields are also required in real scenario, but omit here for brevity
 			})
 			gotToken, err := client.GetToken(context.Background())
-			assert.True(t, serverCallCount.Load() > 0, "server was not called")
+			assert.Greater(t, serverCallCount.Load(), 0, "server was not called")
 
 			if tt.wantErr {
 				require.Error(t, err)

pkg/notifications/notification_test.go

@@ -130,7 +130,7 @@ func TestClient_CreateNotification(t *testing.T) {
 			err := client.CreateNotification(context.Background(), tt.notification)
 
 			if !tt.serverErrors.authenticationFail {
-				assert.True(t, serverCallCount.Load() > 0, "notification server was not called")
+				assert.Greater(t, serverCallCount.Load(), 0, "notification server was not called")
 			}
 
 			if tt.wantErr {