From 43710e3ad79ac1ea5d5beb135578a43f00d2eb62 Mon Sep 17 00:00:00 2001 From: Peter Ashwood Date: Tue, 18 Aug 2026 18:00:06 +0000 Subject: [PATCH] chore: upgrade node to v24 --- .../compute-schematic-matrix/action.yml | 2 +- .../src/compute-matrix.spec.ts | 12 ++++----- .../src/compute-matrix.ts | 2 +- .github/workflows/build.yml | 12 ++++----- .github/workflows/publish.yml | 2 +- .github/workflows/test-commerce-schematic.yml | 4 +-- .github/workflows/upload-search-index.yml | 2 +- .nvmrc | 2 +- package-lock.json | 25 ++++++------------- package.json | 2 +- 10 files changed, 28 insertions(+), 37 deletions(-) diff --git a/.github/actions/compute-schematic-matrix/action.yml b/.github/actions/compute-schematic-matrix/action.yml index 643712e570..62f178f4f2 100644 --- a/.github/actions/compute-schematic-matrix/action.yml +++ b/.github/actions/compute-schematic-matrix/action.yml @@ -10,7 +10,7 @@ inputs: description: "Comma-separated Angular version constraints (e.g. '^19,^20')" node-versions: required: true - description: "Comma-separated Node.js versions (e.g. '22.21.x,20.x')" + description: "Comma-separated Node.js versions (e.g. '24.19.x,20.x')" outputs: matrix: value: ${{ steps.compute.outputs.matrix }} diff --git a/.github/actions/compute-schematic-matrix/src/compute-matrix.spec.ts b/.github/actions/compute-schematic-matrix/src/compute-matrix.spec.ts index 28d3003fc9..482ce4f807 100644 --- a/.github/actions/compute-schematic-matrix/src/compute-matrix.spec.ts +++ b/.github/actions/compute-schematic-matrix/src/compute-matrix.spec.ts @@ -10,7 +10,7 @@ import { } from './path-config'; const REPO_ROOT = join(__dirname, '..', '..', '..', '..'); -const NODE_VERSIONS = ['22.21.x']; +const NODE_VERSIONS = ['24.19.x']; const ANGULAR_VERSIONS = ['^20']; const entryNames = (entries: MatrixEntry[]): string[] => @@ -114,7 +114,7 @@ describe('computeMatrix', () => { it('driver entry has correct defaults', () => { const [demo] = computeMatrix(['libs/dev-tools/src/component.ts'], config, NODE_VERSIONS, ANGULAR_VERSIONS); expect(demo).toEqual({ - node_version: '22.21.x', + node_version: '24.19.x', angular_version: '^20', driver: 'demo', base: 'scss-standalone', @@ -129,7 +129,7 @@ describe('computeMatrix', () => { const entries = computeMatrix(['tools/schematics/ng-add/index.ts'], config, NODE_VERSIONS, ANGULAR_VERSIONS); const entry = entries.find((e) => e.name === 'skip-package-json'); expect(entry).toEqual({ - node_version: '22.21.x', + node_version: '24.19.x', angular_version: '^20', driver: 'in-memory', base: 'scss-standalone', @@ -145,7 +145,7 @@ describe('computeMatrix', () => { const entries = computeMatrix(['tools/schematics/ng-add/index.ts'], config, NODE_VERSIONS, ANGULAR_VERSIONS); const entry = entries.find((e) => e.name === 'module-app-rejection'); expect(entry).toEqual({ - node_version: '22.21.x', + node_version: '24.19.x', angular_version: '^20', driver: 'in-memory', base: 'scss-module', @@ -161,7 +161,7 @@ describe('computeMatrix', () => { const entries = computeMatrix(['tools/schematics/ng-add/index.ts'], config, NODE_VERSIONS, ANGULAR_VERSIONS); const entry = entries.find((e) => e.name === 'css-style-failure'); expect(entry).toEqual({ - node_version: '22.21.x', + node_version: '24.19.x', angular_version: '^20', driver: 'in-memory', base: 'css-standalone', @@ -177,7 +177,7 @@ describe('computeMatrix', () => { const entries = computeMatrix(['tools/schematics/ng-add/index.ts'], config, NODE_VERSIONS, ANGULAR_VERSIONS); const entry = entries.find((e) => e.name === 'no-app-routing'); expect(entry).toEqual({ - node_version: '22.21.x', + node_version: '24.19.x', angular_version: '^20', driver: 'in-memory', base: 'scss-standalone', diff --git a/.github/actions/compute-schematic-matrix/src/compute-matrix.ts b/.github/actions/compute-schematic-matrix/src/compute-matrix.ts index 8ec0bcac7e..11b0682821 100644 --- a/.github/actions/compute-schematic-matrix/src/compute-matrix.ts +++ b/.github/actions/compute-schematic-matrix/src/compute-matrix.ts @@ -12,7 +12,7 @@ import { */ export interface MatrixEntry { /** - * Node.js version for the test runner (e.g. `"22.21.x"`). + * Node.js version for the test runner (e.g. `"24.19.x"`). */ node_version: string; /** diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 5c797866a6..ec98bccee7 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -36,7 +36,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node: [22.21.x] + node: [24.19.x] steps: - uses: actions/checkout@v4 with: @@ -63,7 +63,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - node: [22.21.x] + node: [24.19.x] steps: - uses: actions/checkout@v4 with: @@ -108,7 +108,7 @@ jobs: persist-credentials: false - uses: graycoreio/github-actions/setup-node@main with: - node-version: '22.21.x' + node-version: '24.19.x' npm-version: ${{ env.NPM_VERSION }} use-stamp-cache: true - uses: nrwl/nx-set-shas@v3 @@ -129,7 +129,7 @@ jobs: fail-fast: false matrix: package: ${{ fromJSON(needs.compute_packages.outputs.packages) }} - node: [22.21.x] + node: [24.19.x] needs: - compute_packages - build @@ -163,7 +163,7 @@ jobs: uses: ./.github/workflows/test-commerce-schematic.yml with: ref: ${{ inputs.ref && inputs.ref || github.sha }} - node-versions: '22.21.x' + node-versions: '24.19.x' secrets: NX_KEY: ${{ secrets.NX_KEY }} AZURE_NX_CACHE_READONLY_CONNECTION_STRING: ${{ secrets.AZURE_STORAGE_CONNECTION_STRING || secrets.AZURE_NX_CACHE_READONLY_CONNECTION_STRING }} @@ -180,5 +180,5 @@ jobs: VERCEL_TOKEN: ${{ secrets.VERCEL_TOKEN }} VERCEL_ORG: ${{ secrets.VERCEL_ORG }} with: - artifact: daffio-22.21.x + artifact: daffio-24.19.x artifact-zip-name: daffio.zip diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index c5cd320930..d709de3689 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -34,7 +34,7 @@ jobs: - uses: graycoreio/github-actions/setup-node@main with: - node-version: 22.21.x + node-version: 24.19.x npm-version: ${{ env.NPM_VERSION }} use-stamp-cache: true registry-url: 'https://registry.npmjs.org' diff --git a/.github/workflows/test-commerce-schematic.yml b/.github/workflows/test-commerce-schematic.yml index 862fde730c..bdf0fd4229 100644 --- a/.github/workflows/test-commerce-schematic.yml +++ b/.github/workflows/test-commerce-schematic.yml @@ -9,8 +9,8 @@ on: node-versions: required: false type: string - default: '22.21.x' - description: "Comma-separated Node.js versions (e.g. '22.21.x,20.x')" + default: '24.19.x' + description: "Comma-separated Node.js versions (e.g. '24.19.x,20.x')" angular-versions: required: false type: string diff --git a/.github/workflows/upload-search-index.yml b/.github/workflows/upload-search-index.yml index f5a8bfd3d0..7d52a6a41f 100644 --- a/.github/workflows/upload-search-index.yml +++ b/.github/workflows/upload-search-index.yml @@ -30,7 +30,7 @@ jobs: - uses: graycoreio/github-actions/setup-node@main with: - node-version: 22.21.x + node-version: 24.19.x npm-version: ${{ env.NPM_VERSION }} use-stamp-cache: true diff --git a/.nvmrc b/.nvmrc index bfd0596b91..d8e297d13c 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -22.21 +24.19 diff --git a/package-lock.json b/package-lock.json index a21619044e..8bdccc96a3 100644 --- a/package-lock.json +++ b/package-lock.json @@ -75,7 +75,7 @@ "@types/express": "^5.0.6", "@types/jasmine": "~3.6.0", "@types/jasminewd2": "~2.0.8", - "@types/node": "^22.19.1", + "@types/node": "^24", "@types/nunjucks": "^3.2.6", "@typescript-eslint/eslint-plugin": "^8.53.0", "@typescript-eslint/parser": "^8.53.0", @@ -11637,13 +11637,13 @@ "license": "MIT" }, "node_modules/@types/node": { - "version": "22.19.7", - "resolved": "https://registry.npmjs.org/@types/node/-/node-22.19.7.tgz", - "integrity": "sha512-MciR4AKGHWl7xwxkBa6xUGxQJ4VBOmPTF7sL+iGzuahOFaO0jHCsuEfS80pan1ef4gWId1oWOweIhrDEYLuaOw==", + "version": "24.13.3", + "resolved": "https://registry.npmjs.org/@types/node/-/node-24.13.3.tgz", + "integrity": "sha512-Dh8vAsV36ig5wa9OX4pXvMc9D3Veibfw2wix0CUwYODLD8nkj9UsLjASr49nPg+2eKzxhBV+v7L8pXvT4e639Q==", "devOptional": true, "license": "MIT", "dependencies": { - "undici-types": "~6.21.0" + "undici-types": "~7.18.0" } }, "node_modules/@types/nunjucks": { @@ -31697,9 +31697,9 @@ } }, "node_modules/undici-types": { - "version": "6.21.0", - "resolved": "https://registry.npmjs.org/undici-types/-/undici-types-6.21.0.tgz", - "integrity": "sha512-iwDZqg0QAGrg9Rav5H4n0M64c3mkR59cJ6wQp+7C4nI0gsmExaedaYLNO44eT4AtBBwjbTiGPMlt2Md0T9H9JQ==", + "version": "7.18.2", + "resolved": "https://registry.npmjs.org/undici-types/-/undici-types-7.18.2.tgz", + "integrity": "sha512-AsuCzffGHJybSaRrmr5eHr81mwJU3kjw6M+uprWvCXiNeN9SOGwQ3Jn8jb8m3Z6izVgknn1R0FTCEAP2QrLY/w==", "devOptional": true, "license": "MIT" }, @@ -34358,15 +34358,6 @@ "eslint": "*" } }, - "tools/eslint/daff-packages": { - "name": "eslint-plugin-daff-packages", - "version": "0.0.0", - "extraneous": true, - "peerDependencies": { - "eslint": "*", - "jsonc-eslint-parser": "*" - } - }, "tools/eslint/daff-tsconfig": { "name": "eslint-plugin-daff-tsconfig", "version": "0.0.0", diff --git a/package.json b/package.json index 70072c4452..d17274e210 100644 --- a/package.json +++ b/package.json @@ -75,7 +75,7 @@ "@types/express": "^5.0.6", "@types/jasmine": "~3.6.0", "@types/jasminewd2": "~2.0.8", - "@types/node": "^22.19.1", + "@types/node": "^24", "@types/nunjucks": "^3.2.6", "@typescript-eslint/eslint-plugin": "^8.53.0", "@typescript-eslint/parser": "^8.53.0",