feat: cross-merchant budget enforcement sample#252
Open
Ectsang wants to merge 6 commits into
Open
Conversation
Ectsang
changed the title
Ectsang
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a sample implementation demonstrating the budget enforcement gap in cross-merchant scenarios and provides a solution via an external budget authority. Feedback focuses on improving numerical precision by using round() for currency conversions, optimizing the performance of hold lookups to avoid O(N) complexity, ensuring unique identifiers by using full UUIDs, and enhancing type safety by replacing mixed-type dictionaries with dataclasses.
Author
|
All gemini-code-assist feedback addressed in b547f68 (currency rounding, O(1) hold lookups, full UUIDs, dataclasses). Lint failure is pre-existing Biome, unrelated to this PR — other 3 checks green. Per CONTRIBUTING.md, "contributions going forward are to the samples and sdk only" — this is a sample. @holtskinner anything blocking review from the team side? |
…decision Aligns the cross-merchant budget enforcement sample with the canonical budget_authority verb set being crosswalked across AP2, Cycles, and APS in aeoess/agent-governance-vocabulary. Verbs: - authorize() -> reserve() - refund() -> release() (pre-commit return of unspent reservation) - query() -> query_budget() (budget snapshot) Decision shape: - approved: bool -> decision: Decision (ALLOW / ALLOW_WITH_CAPS / DENY) - This retail sample emits ALLOW or DENY only. ALLOW_WITH_CAPS is canonical for divisible / metered budgets (Cycles, runcycles.io). Callers that cannot accept partial fulfillment MUST treat ALLOW_WITH_CAPS as DENY (safe default). Types renamed for consistency: Hold -> Reservation, AuthorizeResult -> ReserveResult, HoldStatus -> ReservationStatus (REFUNDED -> RELEASED). Demo behavior preserved: Merchant A reserves \$60 (ALLOW), Merchant B denied at \$60 (budget exceeded), Merchant B retries at \$35 (ALLOW). Final state: \$95 spent of \$100 budget. References: - ACP google-agentic-commerce#231 three-layer model (passport / budget authority / rail) - Cycles (runcycles.io) - independent reserve/commit/release impl - aeoess/agent-governance-vocabulary - crosswalk in progress (AAIF donation trajectory documented)
Adds aeoess, crosswalked, goodmeta, runcycles to custom-words for cspell to accept the rename PR's references to upstream verb-set crosswalk and reference implementations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a sample demonstrating the cross-merchant budget enforcement gap from #207 and a solution using an external budget authority.
Part 1 shows the problem: two merchants evaluate
BudgetEvaluatorindependently, each with its ownMandateContext. The agent overspends ($120 on a $100 budget).Part 2 shows the fix: an external authority with four verbs (authorize, commit, refund, query) based on the discussion in #207. The authorize call atomically checks and holds budget, preventing race conditions.
No external dependencies. Runs with
python cross_merchant_budget.py.