Remove use of all-results artifact (#1120)

charisk · web-flow · commit 0ef6b45b1946 · 2022-02-08T08:28:54.000Z
diff --git a/extensions/ql-vscode/src/remote-queries/gh-actions-api-client.ts b/extensions/ql-vscode/src/remote-queries/gh-actions-api-client.ts
@@ -34,8 +34,6 @@ export async function getRemoteQueryIndex(
   const resultIndexArtifactId = getArtifactIDfromName('result-index', workflowUri, artifactList);
   const resultIndexItems = await getResultIndexItems(credentials, owner, repoName, resultIndexArtifactId);
 
-  const allResultsArtifactId = getArtifactIDfromName('all-results', workflowUri, artifactList);
-
   const items = resultIndexItems.map(item => {
     const artifactId = getArtifactIDfromName(item.id, workflowUri, artifactList);
 
@@ -50,9 +48,8 @@ export async function getRemoteQueryIndex(
   });
 
   return {
-    allResultsArtifactId,
     artifactsUrlPath,
-    items,
+    items
   };
 }
 
diff --git a/extensions/ql-vscode/src/remote-queries/remote-queries-interface.ts b/extensions/ql-vscode/src/remote-queries/remote-queries-interface.ts
@@ -80,7 +80,6 @@ export class RemoteQueriesInterfaceManager {
       totalResultCount: totalResultCount,
       executionTimestamp: this.formatDate(query.executionStartTime),
       executionDuration: executionDuration,
-      downloadLink: queryResult.allResultsDownloadLink,
       analysisSummaries: analysisSummaries
     };
   }
diff --git a/extensions/ql-vscode/src/remote-queries/remote-queries-manager.ts b/extensions/ql-vscode/src/remote-queries/remote-queries-manager.ts
@@ -123,11 +123,7 @@ export class RemoteQueriesManager {
 
     return {
       executionEndTime,
-      analysisSummaries,
-      allResultsDownloadLink: {
-        id: resultIndex.allResultsArtifactId.toString(),
-        urlPath: `${resultIndex.artifactsUrlPath}/${resultIndex.allResultsArtifactId}`
-      }
+      analysisSummaries
     };
   }
 }
diff --git a/extensions/ql-vscode/src/remote-queries/remote-query-result-index.ts b/extensions/ql-vscode/src/remote-queries/remote-query-result-index.ts
@@ -1,6 +1,5 @@
 export interface RemoteQueryResultIndex {
   artifactsUrlPath: string;
-  allResultsArtifactId: number;
   items: RemoteQueryResultIndexItem[];
 }
 
diff --git a/extensions/ql-vscode/src/remote-queries/remote-query-result.ts b/extensions/ql-vscode/src/remote-queries/remote-query-result.ts
@@ -3,7 +3,6 @@ import { DownloadLink } from './download-link';
 export interface RemoteQueryResult {
   executionEndTime: Date;
   analysisSummaries: AnalysisSummary[];
-  allResultsDownloadLink: DownloadLink;
 }
 
 export interface AnalysisSummary {
diff --git a/extensions/ql-vscode/src/remote-queries/sample-data.ts b/extensions/ql-vscode/src/remote-queries/sample-data.ts
@@ -38,10 +38,6 @@ export const sampleRemoteQuery: RemoteQuery = {
 
 export const sampleRemoteQueryResult: RemoteQueryResult = {
   executionEndTime: new Date('2022-01-06T17:04:37.026Z'),
-  allResultsDownloadLink: {
-    id: '137697018',
-    urlPath: '/repos/big-corp/controller-repo/actions/artifacts/137697018'
-  },
   analysisSummaries: [
     {
       nwo: 'big-corp/repo1',
diff --git a/extensions/ql-vscode/src/remote-queries/shared/remote-query-result.ts b/extensions/ql-vscode/src/remote-queries/shared/remote-query-result.ts
@@ -10,7 +10,6 @@ export interface RemoteQueryResult {
   totalResultCount: number;
   executionTimestamp: string;
   executionDuration: string;
-  downloadLink: DownloadLink;
   analysisSummaries: AnalysisSummary[]
 }
 
diff --git a/extensions/ql-vscode/src/remote-queries/view/RemoteQueries.tsx b/extensions/ql-vscode/src/remote-queries/view/RemoteQueries.tsx
@@ -30,10 +30,6 @@ const emptyQueryResult: RemoteQueryResult = {
   totalResultCount: 0,
   executionTimestamp: '',
   executionDuration: '',
-  downloadLink: {
-    id: '',
-    urlPath: '',
-  },
   analysisSummaries: []
 };
 

Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,6 @@ export class RemoteQueriesInterfaceManager {`
`80`	`80`	`totalResultCount: totalResultCount,`
`81`	`81`	`executionTimestamp: this.formatDate(query.executionStartTime),`
`82`	`82`	`executionDuration: executionDuration,`
`83`		`- downloadLink: queryResult.allResultsDownloadLink,`
`84`	`83`	`analysisSummaries: analysisSummaries`
`85`	`84`	`};`
`86`	`85`	`}`
Original file line number	Diff line number	Diff line change
`@@ -123,11 +123,7 @@ export class RemoteQueriesManager {`
`123`	`123`
`124`	`124`	`return {`
`125`	`125`	`executionEndTime,`
`126`		`- analysisSummaries,`
`127`		`- allResultsDownloadLink: {`
`128`		`- id: resultIndex.allResultsArtifactId.toString(),`
`129`		- urlPath: `${resultIndex.artifactsUrlPath}/${resultIndex.allResultsArtifactId}`
`130`		`- }`
	`126`	`+ analysisSummaries`
`131`	`127`	`};`
`132`	`128`	`}`
`133`	`129`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,5 @@`
`1`	`1`	`export interface RemoteQueryResultIndex {`
`2`	`2`	`artifactsUrlPath: string;`
`3`		`- allResultsArtifactId: number;`
`4`	`3`	`items: RemoteQueryResultIndexItem[];`
`5`	`4`	`}`
`6`	`5`
Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,6 @@ import { DownloadLink } from './download-link';`
`3`	`3`	`export interface RemoteQueryResult {`
`4`	`4`	`executionEndTime: Date;`
`5`	`5`	`analysisSummaries: AnalysisSummary[];`
`6`		`- allResultsDownloadLink: DownloadLink;`
`7`	`6`	`}`
`8`	`7`
`9`	`8`	`export interface AnalysisSummary {`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,6 @@ export interface RemoteQueryResult {`
`10`	`10`	`totalResultCount: number;`
`11`	`11`	`executionTimestamp: string;`
`12`	`12`	`executionDuration: string;`
`13`		`- downloadLink: DownloadLink;`
`14`	`13`	`analysisSummaries: AnalysisSummary[]`
`15`	`14`	`}`
`16`	`15`