Skip to content

Commit e7b92ab

Browse files
committed
ruby-bench: Prefer --excludes over rm -rf
to remind us of skipped benchmarks in the CI job names
1 parent 34aa97e commit e7b92ab

3 files changed

Lines changed: 12 additions & 6 deletions

File tree

.github/workflows/ubuntu.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ jobs:
208208
matrix:
209209
include:
210210
# Using the same setup as ZJIT jobs
211-
- bench_opts: '--warmup=1 --bench=1'
211+
- bench_opts: '--warmup=1 --bench=1 --excludes=lobsters'
212212

213213
runs-on: ubuntu-24.04
214214

@@ -242,8 +242,10 @@ jobs:
242242
repository: ruby/ruby-bench
243243
path: ruby-bench
244244

245+
# If you want to skip failing benchmark, consider using `--excludes`.
246+
# e.g. `bench_opts: '--warmup=1 --bench=1 --excludes=railsbench,lobsters'`
245247
- name: Run ruby-bench
246-
run: rm -rf benchmarks/lobsters && ruby run_benchmarks.rb -e "ruby::../build/install/bin/ruby" ${{ matrix.bench_opts }}
248+
run: ruby run_benchmarks.rb -e "ruby::../build/install/bin/ruby" ${{ matrix.bench_opts }}
247249
working-directory: ruby-bench
248250

249251
- uses: ./.github/actions/slack

.github/workflows/zjit-macos.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ jobs:
158158
include:
159159
# Test --call-threshold=2 with 2 iterations in total
160160
- ruby_opts: '--zjit-call-threshold=2'
161-
bench_opts: '--warmup=1 --bench=1'
161+
bench_opts: '--warmup=1 --bench=1 --excludes=lobsters'
162162
configure: '--enable-zjit=dev_nodebug' # --enable-zjit=dev is too slow
163163

164164
runs-on: macos-14
@@ -197,8 +197,10 @@ jobs:
197197
repository: ruby/ruby-bench
198198
path: ruby-bench
199199

200+
# If you want to skip failing benchmark, consider using `--excludes`.
201+
# e.g. `bench_opts: '--warmup=1 --bench=1 --excludes=railsbench,lobsters'`
200202
- name: Run ruby-bench
201-
run: rm -rf benchmarks/lobsters && ruby run_benchmarks.rb -e "zjit::../build/install/bin/ruby ${{ matrix.ruby_opts }}" ${{ matrix.bench_opts }}
203+
run: ruby run_benchmarks.rb -e "zjit::../build/install/bin/ruby ${{ matrix.ruby_opts }}" ${{ matrix.bench_opts }}
202204
working-directory: ruby-bench
203205

204206
- uses: ./.github/actions/slack

.github/workflows/zjit-ubuntu.yml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -215,7 +215,7 @@ jobs:
215215
include:
216216
# Test --call-threshold=2 with 2 iterations in total
217217
- ruby_opts: '--zjit-call-threshold=2'
218-
bench_opts: '--warmup=1 --bench=1'
218+
bench_opts: '--warmup=1 --bench=1 --excludes=lobsters'
219219
configure: '--enable-zjit=dev_nodebug' # --enable-zjit=dev is too slow
220220

221221
runs-on: ubuntu-24.04
@@ -250,8 +250,10 @@ jobs:
250250
repository: ruby/ruby-bench
251251
path: ruby-bench
252252

253+
# If you want to skip failing benchmark, consider using `--excludes`.
254+
# e.g. `bench_opts: '--warmup=1 --bench=1 --excludes=railsbench,lobsters'`
253255
- name: Run ruby-bench
254-
run: rm -rf benchmarks/lobsters && ruby run_benchmarks.rb -e "zjit::../build/install/bin/ruby ${{ matrix.ruby_opts }}" ${{ matrix.bench_opts }}
256+
run: ruby run_benchmarks.rb -e "zjit::../build/install/bin/ruby ${{ matrix.ruby_opts }}" ${{ matrix.bench_opts }}
255257
working-directory: ruby-bench
256258

257259
- uses: ./.github/actions/slack

0 commit comments

Comments
 (0)