remove duplicate parse (#2431)

Author: dsyme

pkg/cli/compile_command.go

@@ -49,6 +49,37 @@ func CompileWorkflowWithValidation(compiler *workflow.Compiler, filePath string,
 	return nil
 }
 
+// CompileWorkflowDataWithValidation compiles from already-parsed WorkflowData with validation
+// This avoids re-parsing when the workflow data has already been parsed
+func CompileWorkflowDataWithValidation(compiler *workflow.Compiler, workflowData *workflow.WorkflowData, filePath string, verbose bool) error {
+	// Compile the workflow using already-parsed data
+	if err := compiler.CompileWorkflowData(workflowData, filePath); err != nil {
+		return err
+	}
+
+	// Always validate that the generated lock file is valid YAML (CLI requirement)
+	lockFile := strings.TrimSuffix(filePath, ".md") + ".lock.yml"
+	if _, err := os.Stat(lockFile); err != nil {
+		// Lock file doesn't exist (likely due to no-emit), skip YAML validation
+		return nil
+	}
+
+	compileLog.Print("Validating generated lock file YAML syntax")
+
+	lockContent, err := os.ReadFile(lockFile)
+	if err != nil {
+		return fmt.Errorf("failed to read generated lock file for validation: %w", err)
+	}
+
+	// Validate the lock file is valid YAML
+	var yamlValidationTest any
+	if err := yaml.Unmarshal(lockContent, &yamlValidationTest); err != nil {
+		return fmt.Errorf("generated lock file is not valid YAML: %w", err)
+	}
+
+	return nil
+}
+
 // CompileConfig holds configuration options for compiling workflows
 type CompileConfig struct {
 	MarkdownFiles        []string // Files to compile (empty for all files)
@@ -202,7 +233,7 @@ func CompileWorkflows(config CompileConfig) ([]*workflow.WorkflowData, error) {
 			workflowDataList = append(workflowDataList, workflowData)
 
 			compileLog.Printf("Starting compilation of %s", resolvedFile)
-			if err := CompileWorkflowWithValidation(compiler, resolvedFile, verbose); err != nil {
+			if err := CompileWorkflowDataWithValidation(compiler, workflowData, resolvedFile, verbose); err != nil {
 				// Always put error on a new line and don't wrap with "failed to compile workflow"
 				fmt.Fprintln(os.Stderr, err.Error())
 				errorMessages = append(errorMessages, err.Error())
@@ -343,7 +374,7 @@ func CompileWorkflows(config CompileConfig) ([]*workflow.WorkflowData, error) {
 		}
 		workflowDataList = append(workflowDataList, workflowData)
 
-		if err := CompileWorkflowWithValidation(compiler, file, verbose); err != nil {
+		if err := CompileWorkflowDataWithValidation(compiler, workflowData, file, verbose); err != nil {
 			// Print the error to stderr (errors from CompileWorkflow are already formatted)
 			fmt.Fprintln(os.Stderr, err.Error())
 			errorCount++

pkg/workflow/compiler.go

@@ -221,15 +221,6 @@ type SafeOutputsConfig struct {
 
 // CompileWorkflow converts a markdown workflow to GitHub Actions YAML
 func (c *Compiler) CompileWorkflow(markdownPath string) error {
-
-	// Reset the step order tracker for this compilation
-	c.stepOrderTracker = NewStepOrderTracker()
-
-	// replace the .md extension by .lock.yml
-	lockFile := strings.TrimSuffix(markdownPath, ".md") + ".lock.yml"
-
-	log.Printf("Starting compilation: %s -> %s", markdownPath, lockFile)
-
 	// Parse the markdown file
 	log.Printf("Parsing workflow file")
 	workflowData, err := c.ParseWorkflowFile(markdownPath)
@@ -252,6 +243,21 @@ func (c *Compiler) CompileWorkflow(markdownPath string) error {
 		return errors.New(formattedErr)
 	}
 
+	return c.CompileWorkflowData(workflowData, markdownPath)
+}
+
+// CompileWorkflowData compiles a workflow from already-parsed WorkflowData
+// This avoids re-parsing when the data has already been parsed
+func (c *Compiler) CompileWorkflowData(workflowData *WorkflowData, markdownPath string) error {
+
+	// Reset the step order tracker for this compilation
+	c.stepOrderTracker = NewStepOrderTracker()
+
+	// replace the .md extension by .lock.yml
+	lockFile := strings.TrimSuffix(markdownPath, ".md") + ".lock.yml"
+
+	log.Printf("Starting compilation: %s -> %s", markdownPath, lockFile)
+
 	// Validate expression safety - check that all GitHub Actions expressions are in the allowed list
 	log.Printf("Validating expression safety")
 	if err := validateExpressionSafety(workflowData.MarkdownContent); err != nil {