Consolidate close entity compiler into table-driven registry (#6180)

Author: Copilot

pkg/workflow/close_discussion.go

@@ -146,3 +146,157 @@ func (c *Compiler) buildCloseEntityJob(data *WorkflowData, mainJobName string, c
 		TargetRepoSlug: config.TargetRepoSlug,
 	})
 }
+
+// closeEntityDefinition holds all parameters for a close entity type
+type closeEntityDefinition struct {
+	EntityType       CloseEntityType
+	ConfigKey        string
+	EnvVarPrefix     string
+	JobName          string
+	StepName         string
+	OutputNumberKey  string
+	OutputURLKey     string
+	EventNumberPath1 string
+	EventNumberPath2 string
+	ScriptGetter     func() string
+	PermissionsFunc  func() *Permissions
+	Logger           *logger.Logger
+}
+
+// closeEntityRegistry holds all close entity definitions
+var closeEntityRegistry = []closeEntityDefinition{
+	{
+		EntityType:       CloseEntityIssue,
+		ConfigKey:        "close-issue",
+		EnvVarPrefix:     "GH_AW_CLOSE_ISSUE",
+		JobName:          "close_issue",
+		StepName:         "Close Issue",
+		OutputNumberKey:  "issue_number",
+		OutputURLKey:     "issue_url",
+		EventNumberPath1: "github.event.issue.number",
+		EventNumberPath2: "github.event.comment.issue.number",
+		ScriptGetter:     getCloseIssueScript,
+		PermissionsFunc:  NewPermissionsContentsReadIssuesWrite,
+		Logger:           logger.New("workflow:close_issue"),
+	},
+	{
+		EntityType:       CloseEntityPullRequest,
+		ConfigKey:        "close-pull-request",
+		EnvVarPrefix:     "GH_AW_CLOSE_PR",
+		JobName:          "close_pull_request",
+		StepName:         "Close Pull Request",
+		OutputNumberKey:  "pull_request_number",
+		OutputURLKey:     "pull_request_url",
+		EventNumberPath1: "github.event.pull_request.number",
+		EventNumberPath2: "github.event.comment.pull_request.number",
+		ScriptGetter:     getClosePullRequestScript,
+		PermissionsFunc:  NewPermissionsContentsReadPRWrite,
+		Logger:           logger.New("workflow:close_pull_request"),
+	},
+	{
+		EntityType:       CloseEntityDiscussion,
+		ConfigKey:        "close-discussion",
+		EnvVarPrefix:     "GH_AW_CLOSE_DISCUSSION",
+		JobName:          "close_discussion",
+		StepName:         "Close Discussion",
+		OutputNumberKey:  "discussion_number",
+		OutputURLKey:     "discussion_url",
+		EventNumberPath1: "github.event.discussion.number",
+		EventNumberPath2: "github.event.comment.discussion.number",
+		ScriptGetter:     getCloseDiscussionScript,
+		PermissionsFunc:  NewPermissionsContentsReadDiscussionsWrite,
+		Logger:           logger.New("workflow:close_discussion"),
+	},
+}
+
+// Type aliases for backward compatibility
+type CloseIssuesConfig = CloseEntityConfig
+type ClosePullRequestsConfig = CloseEntityConfig
+type CloseDiscussionsConfig = CloseEntityConfig
+
+// parseCloseIssuesConfig handles close-issue configuration
+func (c *Compiler) parseCloseIssuesConfig(outputMap map[string]any) *CloseIssuesConfig {
+	def := closeEntityRegistry[0] // issue
+	params := CloseEntityJobParams{
+		EntityType: def.EntityType,
+		ConfigKey:  def.ConfigKey,
+	}
+	return c.parseCloseEntityConfig(outputMap, params, def.Logger)
+}
+
+// parseClosePullRequestsConfig handles close-pull-request configuration
+func (c *Compiler) parseClosePullRequestsConfig(outputMap map[string]any) *ClosePullRequestsConfig {
+	def := closeEntityRegistry[1] // pull request
+	params := CloseEntityJobParams{
+		EntityType: def.EntityType,
+		ConfigKey:  def.ConfigKey,
+	}
+	return c.parseCloseEntityConfig(outputMap, params, def.Logger)
+}
+
+// parseCloseDiscussionsConfig handles close-discussion configuration
+func (c *Compiler) parseCloseDiscussionsConfig(outputMap map[string]any) *CloseDiscussionsConfig {
+	def := closeEntityRegistry[2] // discussion
+	params := CloseEntityJobParams{
+		EntityType: def.EntityType,
+		ConfigKey:  def.ConfigKey,
+	}
+	return c.parseCloseEntityConfig(outputMap, params, def.Logger)
+}
+
+// buildCreateOutputCloseIssueJob creates the close_issue job
+func (c *Compiler) buildCreateOutputCloseIssueJob(data *WorkflowData, mainJobName string) (*Job, error) {
+	def := closeEntityRegistry[0] // issue
+	params := CloseEntityJobParams{
+		EntityType:       def.EntityType,
+		ConfigKey:        def.ConfigKey,
+		EnvVarPrefix:     def.EnvVarPrefix,
+		JobName:          def.JobName,
+		StepName:         def.StepName,
+		OutputNumberKey:  def.OutputNumberKey,
+		OutputURLKey:     def.OutputURLKey,
+		EventNumberPath1: def.EventNumberPath1,
+		EventNumberPath2: def.EventNumberPath2,
+		ScriptGetter:     def.ScriptGetter,
+		PermissionsFunc:  def.PermissionsFunc,
+	}
+	return c.buildCloseEntityJob(data, mainJobName, data.SafeOutputs.CloseIssues, params, def.Logger)
+}
+
+// buildCreateOutputClosePullRequestJob creates the close_pull_request job
+func (c *Compiler) buildCreateOutputClosePullRequestJob(data *WorkflowData, mainJobName string) (*Job, error) {
+	def := closeEntityRegistry[1] // pull request
+	params := CloseEntityJobParams{
+		EntityType:       def.EntityType,
+		ConfigKey:        def.ConfigKey,
+		EnvVarPrefix:     def.EnvVarPrefix,
+		JobName:          def.JobName,
+		StepName:         def.StepName,
+		OutputNumberKey:  def.OutputNumberKey,
+		OutputURLKey:     def.OutputURLKey,
+		EventNumberPath1: def.EventNumberPath1,
+		EventNumberPath2: def.EventNumberPath2,
+		ScriptGetter:     def.ScriptGetter,
+		PermissionsFunc:  def.PermissionsFunc,
+	}
+	return c.buildCloseEntityJob(data, mainJobName, data.SafeOutputs.ClosePullRequests, params, def.Logger)
+}
+
+// buildCreateOutputCloseDiscussionJob creates the close_discussion job
+func (c *Compiler) buildCreateOutputCloseDiscussionJob(data *WorkflowData, mainJobName string) (*Job, error) {
+	def := closeEntityRegistry[2] // discussion
+	params := CloseEntityJobParams{
+		EntityType:       def.EntityType,
+		ConfigKey:        def.ConfigKey,
+		EnvVarPrefix:     def.EnvVarPrefix,
+		JobName:          def.JobName,
+		StepName:         def.StepName,
+		OutputNumberKey:  def.OutputNumberKey,
+		OutputURLKey:     def.OutputURLKey,
+		EventNumberPath1: def.EventNumberPath1,
+		EventNumberPath2: def.EventNumberPath2,
+		ScriptGetter:     def.ScriptGetter,
+		PermissionsFunc:  def.PermissionsFunc,
+	}
+	return c.buildCloseEntityJob(data, mainJobName, data.SafeOutputs.CloseDiscussions, params, def.Logger)
+}