Skip to content

Commit 042b7ec

Browse files
[q] fix: exclude cancelled create_discussion results from error export (#27185) (#27210)
1 parent 5496198 commit 042b7ec

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

actions/setup/js/safe_output_handler_manager.cjs

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1241,18 +1241,20 @@ async function main() {
12411241
}
12421242

12431243
// Export create_discussion errors for conclusion job
1244+
// Exclude cancelled results (cancelled == the discussion was skipped because a code-push
1245+
// operation failed earlier in the same run; that failure is already reported separately).
12441246
const createDiscussionErrors = processingResult.results
1245-
.filter(r => r.type === "create_discussion" && !r.success && !r.deferred && !r.skipped)
1247+
.filter(r => r.type === "create_discussion" && !r.success && !r.deferred && !r.skipped && !r.cancelled)
12461248
.map((r, index) => {
12471249
const message = agentOutput.items[r.messageIndex];
12481250
const title = message?.title || "Discussion";
1249-
const repo = message?.repo || "unknown";
1250-
const errorMsg = r.error || "Unknown error";
1251+
const repo = message?.repo || process.env.GITHUB_REPOSITORY || "unknown";
1252+
const errorMsg = r.error || r.reason || "Unknown error";
12511253
return `discussion:${index}:${repo}:${title}:${errorMsg}`;
12521254
})
12531255
.join("\n");
12541256

1255-
const createDiscussionErrorCount = processingResult.results.filter(r => r.type === "create_discussion" && !r.success && !r.deferred && !r.skipped).length;
1257+
const createDiscussionErrorCount = processingResult.results.filter(r => r.type === "create_discussion" && !r.success && !r.deferred && !r.skipped && !r.cancelled).length;
12561258

12571259
core.setOutput("create_discussion_errors", createDiscussionErrors);
12581260
core.setOutput("create_discussion_error_count", createDiscussionErrorCount.toString());

0 commit comments

Comments
 (0)