Skip to content

Commit 9d456f6

Browse files
Copilotbrunoborges
andauthored
Remove unused LOG fields, use newSingleThreadExecutor for Java 21 overlay, fix empty docs section
Agent-Logs-Url: https://github.com/github/copilot-sdk-java/sessions/46706dd3-402c-41c9-9150-3cfae7db8c3f Co-authored-by: brunoborges <129743+brunoborges@users.noreply.github.com>
1 parent fef1833 commit 9d456f6

File tree

3 files changed

+1
-12
lines changed

3 files changed

+1
-12
lines changed

src/main/java/com/github/copilot/sdk/ThreadFactoryProvider.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
import java.util.concurrent.ExecutorService;
88
import java.util.concurrent.Executors;
9-
import java.util.logging.Logger;
109

1110
/**
1211
* Provides thread factories for the SDK's internal thread creation.
@@ -24,8 +23,6 @@
2423
*/
2524
final class ThreadFactoryProvider {
2625

27-
private static final Logger LOG = Logger.getLogger(ThreadFactoryProvider.class.getName());
28-
2926
private ThreadFactoryProvider() {
3027
}
3128

src/main/java21/com/github/copilot/sdk/ThreadFactoryProvider.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66

77
import java.util.concurrent.ExecutorService;
88
import java.util.concurrent.Executors;
9-
import java.util.logging.Logger;
109

1110
/**
1211
* Java 21+ override that uses virtual threads for the SDK's internal thread
@@ -20,8 +19,6 @@
2019
*/
2120
final class ThreadFactoryProvider {
2221

23-
private static final Logger LOG = Logger.getLogger(ThreadFactoryProvider.class.getName());
24-
2522
private ThreadFactoryProvider() {
2623
}
2724

src/site/markdown/advanced.md

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1262,12 +1262,7 @@ The SDK JAR includes `Multi-Release: true` in its manifest. On Java 21+, the JVM
12621262

12631263
### Verifying Virtual Thread Usage
12641264

1265-
You can check at runtime whether the SDK is using virtual threads:
1266-
1267-
```java
1268-
// Thread names are preserved for debuggability regardless of thread type.
1269-
// On Java 21+, the jsonrpc-reader and cli-stderr-reader threads will be virtual.
1270-
```
1265+
Thread names are preserved for debuggability regardless of thread type. On Java 21+, a thread dump will show `jsonrpc-reader` and `cli-stderr-reader` as virtual threads rather than platform threads. You can verify this via `jcmd <pid> Thread.dump_to_file -format=json <file>` or your IDE's thread inspector.
12711266

12721267
## Next Steps
12731268

0 commit comments

Comments
 (0)