Skip to content

Commit 03cfc35

Browse files
Copilotedburns
andauthored
Apply review suggestions: fix assignee, grammar, and refererce-impl typo
Agent-Logs-Url: https://github.com/github/copilot-sdk-java/sessions/b635280e-2e95-4f3d-a5d9-a261f99c6e74 Co-authored-by: edburns <75821+edburns@users.noreply.github.com>
1 parent df6a925 commit 03cfc35

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

.github/workflows/weekly-reference-impl-sync.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ tools:
2424
safe-outputs:
2525
create-issue:
2626
title-prefix: "[reference-impl-sync] "
27-
assignees: [copilot]
27+
assignees: [copilot-swe-agent]
2828
labels: [reference-impl-sync]
2929
expires: 6
3030
close-issue:
@@ -59,8 +59,8 @@ Clone the reference implementation repository and compare commits:
5959

6060
```bash
6161
LAST_MERGE=$(cat .lastmerge)
62-
git clone --quiet https://github.com/github/copilot-sdk.git /tmp/gh-aw/agent/refererce-impl
63-
cd /tmp/gh-aw/agent/refererce-impl
62+
git clone --quiet https://github.com/github/copilot-sdk.git /tmp/gh-aw/agent/reference-impl
63+
cd /tmp/gh-aw/agent/reference-impl
6464
REFERENCE_IMPL_HEAD=$(git rev-parse HEAD)
6565
```
6666

@@ -84,8 +84,8 @@ Go to Step 3b.
8484

8585
### Step 3b: Changes detected
8686

87-
1. Search for any open issues with the `refererce-impl-sync` label using the GitHub MCP tools.
88-
2. Close each existing open `refererce-impl-sync` issue using the `close_issue` safe-output tool with a comment: "Superseded by a newer reference implementation sync check."
87+
1. Search for any open issues with the `reference-impl-sync` label using the GitHub MCP tools.
88+
2. Close each existing open `reference-impl-sync` issue using the `close_issue` safe-output tool with a comment: "Superseded by a newer reference implementation sync check."
8989
3. Create a new issue using the `create_issue` safe-output tool with:
9090
- **Title:** `Reference Implementation sync: <COMMIT_COUNT> new commits (<YYYY-MM-DD>)`
9191
- **Body:** Include the following information:

docs/adr/adr-001-semver-pre-general-availability.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ We took an architectural decision to enable us to pursue investigating this poss
2020

2121
Chosen option: "Track SemVer of reference implementation, with one exception.", because this enables us to pursue Virtual Threads without delaying the first public release of `copilot-sdk-java`. Also, we're supposed to be aggressively modernizing our customers.
2222

23-
To some extent, I would use qualifiers to mark a release as having some feature that is awaiting an reference implementation full release before it goes full ga, i.e you put out 0.1.46-virtualthreads.3 until reference implementation is ready to move to 0.2.0 then you release your virtual threads change and go 0.2.0. So I would make your agreement that your version numbers would match with the exception of qualifiers that you might add in exceptional circumstances.
23+
To some extent, I would use qualifiers to mark a release as having some feature that is awaiting a reference implementation full release before it goes full ga, i.e you put out 0.1.46-virtualthreads.3 until reference implementation is ready to move to 0.2.0 then you release your virtual threads change and go 0.2.0. So I would make your agreement that your version numbers would match with the exception of qualifiers that you might add in exceptional circumstances.
2424

2525
## Related work items
2626

0 commit comments

Comments
 (0)